[v14.x backport] Forces Powershell to use tls1.2 #34461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: nodejs#33140 PR-URL: nodejs#33609 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs-github-bot
added
install
1 similar comment
This was referenced Jul 22, 2020
MylesBorins
force-pushed
the
v14.x-staging
branch
from
1b9bfb1
to
9814a2d
Compare
6 tasks
ruyadorno
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
e196858
to
358b934
Compare
BethGriggs
approved these changes
Aug 4, 2020
This was referenced Aug 5, 2020
|
On the one hand, the commit message here should be fixed, on the other hand, it should probably also match the one on master – what do we usually do in that type of situation? |
This was referenced Aug 9, 2020
Merged
This was referenced Aug 11, 2020
codebytere
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
92340c9
to
b30b518
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: #33140 Backport-PR-URL: #34461 PR-URL: #33609 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.
Fixes: #33140
PR-URL: #33609
Reviewed-By: Bartosz Sosnowski bartosz@janeasystems.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes