Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix legacy pipe error handling #35257

Closed
wants to merge 2 commits into from

Conversation

@ronag
Copy link
Member

@ronag ronag commented Sep 18, 2020

Fixes: #35237

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag ronag requested a review from mcollina Sep 18, 2020
@ronag ronag force-pushed the legacy-error-handling branch 2 times, most recently from 0aace1a to c07e7a5 Sep 18, 2020
@ronag ronag changed the title Legacy error handling stream: fix legacy pipe error handling Sep 18, 2020
@ronag ronag force-pushed the legacy-error-handling branch from c07e7a5 to 85a930c Sep 18, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 18, 2020

lib/internal/streams/util.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the legacy-error-handling branch from edf0ed1 to 56e479b Sep 20, 2020
@ronag ronag requested a review from mcollina Sep 20, 2020
@ronag
Copy link
Member Author

@ronag ronag commented Sep 20, 2020

@Trott
Copy link
Member

@Trott Trott commented Sep 22, 2020

Needs a rebase. Looks good to me, but I'm usually hesitant to 👍 a streams change without someone from @nodejs/streams 👍 it first.

Copy link
Member

@mcollina mcollina left a comment

lgtm

@ronag ronag force-pushed the legacy-error-handling branch from 56e479b to f750a74 Sep 22, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 22, 2020

lpinca
lpinca approved these changes Sep 22, 2020
test/parallel/test-stream-pipe-error-handling.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the legacy-error-handling branch from 8f4f1a6 to c215a0e Sep 22, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 22, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Sep 23, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35257
✔  Done loading data for nodejs/node/pull/35257
----------------------------------- PR info ------------------------------------
Title      stream: fix legacy pipe error handling  (#35257)
Author     Robert Nagy  (@ronag)
Branch     ronag:legacy-error-handling -> nodejs:master
Labels     lts-watch-v12.x, stream
Commits    2
 - stream: fix legacy pipe error handling
 - fixup
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/35257
Fixes: https://github.com/nodejs/node/issues/35237
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35257
Fixes: https://github.com/nodejs/node/issues/35237
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fixup
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-09-22T20:58:51Z: https://ci.nodejs.org/job/node-test-pull-request/33202/
- Querying data for job/node-test-pull-request/33202/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 18 Sep 2020 13:39:55 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35257#pullrequestreview-493519435
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35257#pullrequestreview-493754259
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@ronag
Copy link
Member Author

@ronag ronag commented Sep 23, 2020

@mcollina do you know if the commit queue auto squashes?

Trott
Trott approved these changes Sep 23, 2020
Trott added a commit to Trott/io.js that referenced this issue Sep 23, 2020
Fixes: nodejs#35237

PR-URL: nodejs#35257
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

@Trott Trott commented Sep 23, 2020

Landed in 6be80e1

@Trott Trott closed this Sep 23, 2020
@lundibundi
Copy link
Member

@lundibundi lundibundi commented Sep 23, 2020

@ronag no it doesn't, it will only autosquash if used with --fixup git command
see #34969 (comment) for more information.

I've implemented nodejs/node-core-utils#490 but it is not yet integrated into this repo.
(also - #34770)

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Sep 24, 2020

This doesn't land cleanly on v14.x

@ronag would you be able to backport?

joesepi added a commit to joesepi/node that referenced this issue Jan 8, 2021
Fixes: nodejs#35237

PR-URL: nodejs#35257
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this issue May 16, 2021
Fixes: #35237

PR-URL: #35257
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
Fixes: #35237

PR-URL: #35257
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants