Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] build: expose napi_build_version variable #35266

Closed
wants to merge 1 commit into from
Closed

[v10.x] build: expose napi_build_version variable #35266

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Expose napi_build_version to allow node-gyp to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
Reviewed-By: @gabrielschulhof
Reviewed-By: @lpinca
Reviewed-By: @richardlau
Reviewed-By: @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. v10.x labels Sep 19, 2020
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Sep 19, 2020
@NickNaso
build: expose napi_build_version variable
248df1b 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: nodejs#27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof force-pushed the backport-napi_build_version-to-v10.x branch from bf373c5 to 248df1b Compare September 19, 2020 03:46
@gabrielschulhof
Copy link
Contributor Author

@NickNaso can you please link the issue that has recently cropped up because we forgot to backport this PR?

mhdawson
mhdawson approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems very low risk and we had an issue reported where a N-API module failed to build because it could not check the value.

@NickNaso
Copy link
Member

Hi everybody sorry for the late.
The issue was opened on node-gyp repo nodejs/node-gyp#2224

@richardlau
Copy link
Member

Are there likely to be any other n-api related things that need to land on 10.x? We don't have any regular scheduled releases for 10.x now it is in maintenance1 so I'm trying to gauge how much content we'll have to put out in a release.

1To clarify, I'm okay with this landing on 10.x, just working through the logistics of how we actually get it into what release.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33236/

@gabrielschulhof
Copy link
Contributor Author

@richardlau the PR that marks N-API 7 as stable must still land.

@gabrielschulhof
Copy link
Contributor Author

@richardlau #35336

@richardlau
Copy link
Member

@richardlau the PR that marks N-API 7 as stable must still land.

Thanks. FWIW we discussed the plan for Node.js v10.x at the most recent Release WG meeting (nodejs/Release#614) and the current idea is to look to do a release in about a month's time.

richardlau pushed a commit that referenced this pull request Oct 7, 2020
@NickNaso @richardlau
build: expose napi_build_version variable
b83f9a5 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Backport-PR-URL: #35266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau
Copy link
Member

Landed in b83f9a5.

@richardlau richardlau closed this Oct 7, 2020
@gabrielschulhof gabrielschulhof mentioned this pull request Oct 7, 2020
Closed
@gabrielschulhof gabrielschulhof deleted the backport-napi_build_version-to-v10.x branch January 28, 2021 00:14
@gabrielschulhof gabrielschulhof restored the backport-napi_build_version-to-v10.x branch January 28, 2021 05:40
@gabrielschulhof gabrielschulhof deleted the backport-napi_build_version-to-v10.x branch February 3, 2021 07:17
@roman-r-m roman-r-m mentioned this pull request Mar 13, 2021
Open
@roman-r-m roman-r-m mentioned this pull request May 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gabrielschulhof @NickNaso @richardlau @nodejs-github-bot @mhdawson