test: update error message keywords #39826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file`
nodejs-github-bot
added
needs-ci
|
The failed error message is: |
cjihrig
approved these changes
Aug 21, 2021
richardlau
approved these changes
Aug 21, 2021
|
This isn't currently failing on our CI -- I guess this is particular to new versions of macOS? |
@richardlau I upgrade to macOS Monterey and run into this issue. |
targos
approved these changes
Aug 22, 2021
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Aug 22, 2021
XadillaX
approved these changes
Aug 26, 2021
jasnell
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Aug 26, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
|
Landed in 340161b |
targos
pushed a commit
that referenced
this pull request
Sep 1, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
This testcase failed on Apple Silicon M1, add the error message pattern: `not a mach-o file` PR-URL: #39826 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase failed on Apple Silicon M1, add the error message pattern:
not a mach-o file