-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move util.toUSVString() outside of deprecated group #39840
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
util
Issues and PRs related to the built-in util module.
labels
Aug 22, 2021
lpinca
force-pushed
the
move/tousvstring-documentation
branch
from
August 22, 2021 06:06
e82c393
to
6737257
Compare
targos
approved these changes
Aug 22, 2021
Fast-track has been requested by @targos. Please 👍 to approve. |
ZYSzys
approved these changes
Aug 22, 2021
RaisinTen
approved these changes
Aug 22, 2021
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 22, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 22, 2021
Landed in 82ae00c...0073831 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: #39840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This also happened to fix a markdown lint error that snuck in while the linter was broken. 👍 |
targos
pushed a commit
that referenced
this pull request
Aug 23, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: #39840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: #39840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849