-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: pass opts to EventEmitter.init
#41414
Merged
nodejs-github-bot
merged 2 commits into
nodejs:master
from
MoonBall:fix-miss-opts-param
Jan 19, 2022
Merged
domain: pass opts to EventEmitter.init
#41414
nodejs-github-bot
merged 2 commits into
nodejs:master
from
MoonBall:fix-miss-opts-param
Jan 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jan 6, 2022
ZYSzys
approved these changes
Jan 6, 2022
apapirovski
approved these changes
Jan 6, 2022
aduh95
approved these changes
Jan 6, 2022
This was referenced Jan 7, 2022
22 tasks
26 tasks
16 tasks
13 tasks
Landed in 22792c8 |
17 tasks
Are fixes like these ever backported or only to LTS? |
This is semver-patch, it should be automatically backported to v17.x. Once there's a v17.x version with this change, it should be automatically backported to v16.x two weeks after that. If a conflict arises that blocks the backport, the backporter team usually comments on the issue asking for a manual backport. |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41414 Fixes: nodejs#41391 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
domain
Issues and PRs related to the domain subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
domain
module override theEventEmitter.init
but not pass the params to origin function.Since
repl
module requiredomain
module, the root cause of #41391 is indomain
module.Fixes: #41391