http2: fix prefixed headers order #41735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http2
ofirbarak
force-pushed
the
http-prfixed-headers-order
branch
from
cce4dce
to
32f9aaf
Compare
jasnell
approved these changes
Jan 28, 2022
mcollina
reviewed
Jan 28, 2022
Trott
previously requested changes
Jan 29, 2022
There was a problem hiding this comment.
Welcome @ofirbarak and thanks for the pull request. Are you able to rebase to edit the first commit message so that it starts with http2: rather than lib:, and then force push to your branch?
If this change doesn't happen and some collaborator wants to land this anyway, that's fine, clear this objection, but please make sure to land manually so you can edit the commit message yourself. Thanks!
added 4 commits
January 30, 2022 15:08
Keep pseudo-headers order same as sent order Fixes: nodejs#38797
ofirbarak
force-pushed
the
http-prfixed-headers-order
branch
from
378aa75
to
cc03955
Compare
ofirbarak
changed the title
This was referenced Feb 2, 2022
|
Landed in ee4bd95 |
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
Keep pseudo-headers order same as sent order Fixes: nodejs#38797 PR-URL: nodejs#41735 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
Keep pseudo-headers order same as sent order Fixes: nodejs#38797 PR-URL: nodejs#41735 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep prefixed headers order same as sent order
Fixes: #38797