doc: remove ETW tool from tier list #43295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Jun 2, 2022
gireeshpunathil
approved these changes
Jun 2, 2022
Flarna
approved these changes
Jun 2, 2022
RafaelGSS
approved these changes
Jun 2, 2022
tniessen
approved these changes
Jun 3, 2022
cjihrig
approved these changes
Jun 4, 2022
|
This might need to be rebased for the linter to pass, see #43298. |
I'll do it ^^ |
|
@tony-go can you please remove the merge commit? |
|
Hi, @tony-go hope this is not too late for the party, we do use ETW in some of our customers as a crucial part of their instrumentation and diagnostic tooling. Not sure if this is enough to keep it on the list nor if there is a minimum requirement for it. I'm pretty happy to help if you need more details about use cases or anything else that might help. |
tony-go
force-pushed
the
remove-etw-tierlist
branch
from
3b4a277
to
c532659
Compare
|
Hi @romulocintra 馃憢 Thanks for sharing ^^ What we tend to achieve here is more to give a clear picture for newcomers than decide if a tool should be used or not. Then we could delete it for now and put it back later.
Yeah, for sure:
Also, you can find all the required criteria in the document itself. |
jasnell
approved these changes
Jun 13, 2022
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3786ef6 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 14, 2022
PR-URL: #43295 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard St枚bich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nie脽en <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43295 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard St枚bich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nie脽en <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43295 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard St枚bich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nie脽en <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43295 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard St枚bich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nie脽en <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢 Guess who's back?
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
ETWmodule: issue link.We decide to remove it, as anyone in the instance has an idea about a potential usage in the field. We prefer to have a list that contains fewer items but is trustable. In case you have a different opinion, please share your thoughts in this PR 馃檹.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love 鉂わ笍
cc @nodejs/diagnostics