-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test to improve coverage in test-http2-compat-serverresponse-write.js #44970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
request.resume(); | ||
request.on('end', mustCall()); | ||
request.on('close', mustCall(() => { | ||
client.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both this and client.destroy();
below needed? I would keep only one if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is not necessary, just pushed a new commit for that. Thanks
0c1dfec
to
60dfde0
Compare
CI failing is not related to this change. Requesting a CI run again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lpinca PTAL |
@Cesar-M-Diaz it seems good to me but I'm not sure I understand what is tested in particular. Can you please add a comment or clarify how coverage is increased with a link or an image? Thanks. |
@lpinca Im covering this statement with the test |
Thanks. |
Landed in 4264b19 |
PR-URL: #44970 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44970 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44970 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44970 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44970 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Added a test to complement the test coverage on this file test-http2-compat-serverresponse-write.js