-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: forbid running watch mode in REPL #45058
Conversation
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/45058 ✔ Done loading data for nodejs/node/pull/45058 ----------------------------------- PR info ------------------------------------ Title src: forbid running watch mode in REPL (#45058) Author Moshe Atlow (@MoLow) Branch MoLow:watch-mode-no-repl -> nodejs:main Labels c++, author ready, needs-ci, watch-mode Commits 2 - src: forbid running watch mode in REPL - Update src/node_options.cc Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/45058 Fixes: https://github.com/nodejs/node/issues/45006 Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45058 Fixes: https://github.com/nodejs/node/issues/45006 Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Oct 2022 17:52:51 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45058#pullrequestreview-1146304597 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45058#pullrequestreview-1148792149 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-20T07:11:55Z: https://ci.nodejs.org/job/node-test-pull-request/47357/ - Querying data for job/node-test-pull-request/47357/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45058 From https://github.com/nodejs/node * branch refs/pull/45058/merge -> FETCH_HEAD ✔ Fetched commits as e7645fab79be..ca4d76b22f30 -------------------------------------------------------------------------------- [main f5f00b59ea] src: forbid running watch mode in REPL Author: Moshe Atlow Date: Tue Oct 18 17:52:15 2022 +0000 4 files changed, 27 insertions(+), 20 deletions(-) [main c8e659e9cf] Update src/node_options.cc Author: Moshe Atlow Date: Wed Oct 19 15:10:53 2022 +0300 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3291957192 |
Landed in c8264ad |
Fixes: #45006