-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "deps: V8: forward declaration of Rtl*FunctionTable
"
#45119
Conversation
This reverts commit 01bc8e6.
Review requested:
|
Sounds like a bug to me, I've sent a PR to fix it: nodejs/core-validate-commit#102. |
Windows CI is green! |
Commit Queue failed- Loading data for nodejs/node/pull/45119 ✔ Done loading data for nodejs/node/pull/45119 ----------------------------------- PR info ------------------------------------ Title Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" (#45119) Author Michaël Zasso (@targos) Branch targos:revert-rtl -> nodejs:main Labels build, v8 engine, needs-ci Commits 1 - Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/45119 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45119 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Oct 2022 08:28:52 GMT ✔ Approvals: 3 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151903319 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151981244 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1152057526 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-10-22T16:51:58Z: https://ci.nodejs.org/job/node-test-pull-request/47397/ ℹ Last V8 CI on 2022-10-22T09:35:01Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4938/ - Querying data for job/node-test-pull-request/47397/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3317858880 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reran the lint-commit-message
job after releasing nodejs/core-validate-commit#102 and GitHub CI is green now, LGTM.
Landed in c6c18a9 |
This reverts commit 01bc8e6.
Refs: #45118