-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: fix debugStream method #45129
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
santigimeno:santi/http2_fix_debug_log
Oct 25, 2022
Merged
http2: fix debugStream method #45129
nodejs-github-bot
merged 1 commit into
nodejs:main
from
santigimeno:santi/http2_fix_debug_log
Oct 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it actually logs something when debug is activated.
Review requested:
|
nodejs-github-bot
added
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
labels
Oct 22, 2022
jasnell
approved these changes
Oct 22, 2022
lpinca
approved these changes
Oct 22, 2022
cjihrig
approved these changes
Oct 22, 2022
daeyeon
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Oct 23, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 23, 2022
13 tasks
The CI failed in macOS w/ |
juanarbol
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
16 tasks
mcollina
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 25, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 25, 2022
Landed in bb7650b |
MrJithil
pushed a commit
to MrJithil/node
that referenced
this pull request
Oct 25, 2022
So it actually logs something when debug is activated. PR-URL: nodejs#45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This was referenced Oct 26, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
So it actually logs something when debug is activated. PR-URL: #45129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it actually logs something when debug is activated.