-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve test coverage in test-event-capture-rejections.js
#45148
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
juanarbol:juan/events-test-coverage
Oct 29, 2022
Merged
test: improve test coverage in test-event-capture-rejections.js
#45148
nodejs-github-bot
merged 1 commit into
nodejs:main
from
juanarbol:juan/events-test-coverage
Oct 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Oct 24, 2022
cjihrig
approved these changes
Oct 24, 2022
jasnell
approved these changes
Oct 26, 2022
benjamingr
approved these changes
Oct 26, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 27, 2022
juanarbol
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 27, 2022
15 tasks
lpinca
approved these changes
Oct 29, 2022
anonrig
approved these changes
Oct 29, 2022
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 29, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 29, 2022
Landed in cca44bc |
15 tasks
This was referenced Oct 31, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
15 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan José Arboleda soyjuanarbol@gmail.com