-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: run license-builder #45553
doc: run license-builder #45553
Conversation
Review requested:
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
@@ -1040,9 +1040,9 @@ The externally maintained libraries used by Node.js are: | |||
- zlib, located at deps/zlib, is licensed as follows: | |||
""" | |||
zlib.h -- interface of the 'zlib' general purpose compression library | |||
version 1.2.11, January 15th, 2017 | |||
version 1.2.13, October 13th, 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zlib on the main branch is still v1.2.12: b6c108f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deps/zlib/zlib.h
says 1.2.13. 🤷 deps/zlib/LICENSE
says 1.2.12 though. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://chromium.googlesource.com/chromium/src/third_party/zlib indicates that 8bbd6c31 is 1.2.13, so I think this commit is correct and the zlib LICENSE file didn't get updated for the release. So I think we're good.
Landed in abadaca |
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: nodejs#45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #45553 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
License is likely out of date. This is an automatically generated PR by the
license-builder.yml
GitHub Action, which runslicense-builder.sh
and submits a new PR or updates an existing PR.