Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: refactor to use validateStringArray #46012

Conversation

deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Dec 29, 2022

options.categories is string[]. So used validateStringArray

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 29, 2022
@deokjinkim deokjinkim force-pushed the 221229_refactor_use_validatestringarray branch from 98d5622 to e972208 Compare December 29, 2022 09:53
@deokjinkim deokjinkim force-pushed the 221229_refactor_use_validatestringarray branch from e972208 to 16e55e5 Compare December 29, 2022 16:26
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8a74477 into nodejs:main Jan 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 8a74477

RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
`options.categories` is string[]. So used `validateStringArray`

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions
PR-URL: #46012
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
`options.categories` is string[]. So used `validateStringArray`

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions
PR-URL: #46012
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
`options.categories` is string[]. So used `validateStringArray`

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions
PR-URL: #46012
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants