-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace_events: refactor to use validateStringArray
#46012
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221229_refactor_use_validatestringarray
Jan 19, 2023
Merged
trace_events: refactor to use validateStringArray
#46012
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221229_refactor_use_validatestringarray
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
trace_events
Issues and PRs related to V8, Node.js core, and userspace code trace events.
labels
Dec 29, 2022
deokjinkim
force-pushed
the
221229_refactor_use_validatestringarray
branch
from
December 29, 2022 09:53
98d5622
to
e972208
Compare
`options.categories` is string[]. So used `validateStringArray` Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions
deokjinkim
force-pushed
the
221229_refactor_use_validatestringarray
branch
from
December 29, 2022 16:26
e972208
to
16e55e5
Compare
lpinca
approved these changes
Jan 1, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 1, 2023
22 tasks
This was referenced Jan 3, 2023
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 19, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 19, 2023
Landed in 8a74477 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
`options.categories` is string[]. So used `validateStringArray` Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions PR-URL: #46012 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
`options.categories` is string[]. So used `validateStringArray` Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions PR-URL: #46012 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
`options.categories` is string[]. So used `validateStringArray` Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions PR-URL: #46012 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
trace_events
Issues and PRs related to V8, Node.js core, and userspace code trace events.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.categories
is string[]. So usedvalidateStringArray
Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions