Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Keep PipeWrap::Open function consistent with TCPWrap #46064

Merged
merged 1 commit into from
Jan 6, 2023
Merged

src: Keep PipeWrap::Open function consistent with TCPWrap #46064

merged 1 commit into from
Jan 6, 2023

Conversation

theanarkh
Copy link
Contributor

Keep PipeWrap::Open function consistent with TCPWrap.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jan 2, 2023
@theanarkh theanarkh force-pushed the keep_the_return_value_of_open_function_consistent branch from de44085 to 2f2f384 Compare January 2, 2023 16:56
@theanarkh theanarkh force-pushed the keep_the_return_value_of_open_function_consistent branch from 2f2f384 to ab9f98a Compare January 2, 2023 17:05
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48826/

@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48836/

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 4, 2023
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Open
22 tasks
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9e86c49 into nodejs:main Jan 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9e86c49

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@theanarkh @RafaelGSS
src: keep PipeWrap::Open function consistent with TCPWrap
ff1bcd0 
PR-URL: nodejs#46064
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@theanarkh @RafaelGSS
src: keep PipeWrap::Open function consistent with TCPWrap
ca8ff08 
PR-URL: #46064
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@theanarkh @juanarbol
src: keep PipeWrap::Open function consistent with TCPWrap
9505c38 
PR-URL: #46064
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@theanarkh @juanarbol
src: keep PipeWrap::Open function consistent with TCPWrap
b454a76 
PR-URL: #46064
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theanarkh @nodejs-github-bot @addaleax @RaisinTen