-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: duplex and readable from
uncaught exception
#46135
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
marco-ippolito:fix/duplex-readble-array-warning
Jan 11, 2023
Merged
doc: duplex and readable from
uncaught exception
#46135
nodejs-github-bot
merged 4 commits into
nodejs:main
from
marco-ippolito:fix/duplex-readble-array-warning
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from
uncaught exeception warningfrom
uncaught exception warning
from
uncaught exception warningfrom
uncaught exception
Trott
reviewed
Jan 8, 2023
Trott
reviewed
Jan 8, 2023
Trott
reviewed
Jan 8, 2023
Trott
reviewed
Jan 8, 2023
@nodejs/streams @nodejs/documentation |
mcollina
reviewed
Jan 8, 2023
ShogunPanda
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
aymen94
approved these changes
Jan 10, 2023
It's |
mcollina
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Landed in 611d5b4 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46135 Fixes: nodejs#46071 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
doc
Issues and PRs related to the documentations.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #46071
Warning the user that using
Duplex.from
orReadable.from
passing an iterable with promises as argument, could lead to uncaught exceptions