Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use UNREACHABLE instead of CHECK(falsy) #46317

Merged
merged 1 commit into from
Jan 25, 2023
Merged

src: use UNREACHABLE instead of CHECK(falsy) #46317

merged 1 commit into from
Jan 25, 2023

Conversation

tniessen
Copy link
Member

Also remove some dead code following such statements.

@tniessen
src: use UNREACHABLE instead of CHECK(falsy)
968c3a3 
Also remove some dead code following such statements.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 23, 2023
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49143/

@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Open
13 tasks
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2023
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Open
12 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit f0e6453 into nodejs:main Jan 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f0e6453

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@tniessen @ruyadorno
src: use UNREACHABLE instead of CHECK(falsy)
e7b507a 
Also remove some dead code following such statements.

PR-URL: #46317
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@tniessen @juanarbol
src: use UNREACHABLE instead of CHECK(falsy)
d3621c8 
Also remove some dead code following such statements.

PR-URL: #46317
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@tniessen @juanarbol
src: use UNREACHABLE instead of CHECK(falsy)
88614c5 
Also remove some dead code following such statements.

PR-URL: #46317
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@tniessen @juanarbol
src: use UNREACHABLE instead of CHECK(falsy)
bdb793a 
Also remove some dead code following such statements.

PR-URL: #46317
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @fhinkel @addaleax @lpinca @anonrig @RaisinTen