Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: isolate hr-time specific wpt global init #46795

Merged
merged 1 commit into from
Feb 25, 2023
Merged

test: isolate hr-time specific wpt global init #46795

merged 1 commit into from
Feb 25, 2023

Conversation

panva
Copy link
Member

@panva panva commented Feb 23, 2023

This removes a global scope WPT hack and only adds it to the WPT that needs it (hr-time).

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 23, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49936/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49951/

@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49971/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 32a907a into nodejs:main Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 32a907a

@panva panva deleted the wpt-hr-time-cleanup branch February 25, 2023 15:59
This was referenced Feb 26, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
test: isolate hr-time specific wpt global init
76a9634 
PR-URL: #46795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams
Copy link
Contributor

I think this is dependent on #44483

@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @danielleadams @jasnell @targos