Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update WPT fixtures resources, common, streams, FileAPI #46912

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Mar 2, 2023

Pulled in updated testharness (resources), which prompted the update to resources, then streams, then FileAPI.

The non fixture changes are

  • set the right globals so that the updated testharness gets used to determine the right test titles in the ShellTestEnvironment we end up utilizing (thanks to web-platform-tests/wpt@46e1750)
  • tests that require gc now load a specific script, when that script is detected the worker automatically loads and assigns gc to globalThis
  • cleanup of fixture files that are no longer in the wpt repo that aren't cleaned up during git node wpt ... (issue opened git node wpt only updates or creates files, doesn't remove them node-core-utils#678)
  • re-fetching webmessaging/broadcastchannel that was missing in versions.json

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 2, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@nodejs-github-bot

This comment was marked as outdated.

@panva panva marked this pull request as draft March 2, 2023 18:05
@panva panva marked this pull request as ready for review March 2, 2023 18:51
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Mar 3, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 6, 2023

@panva
Copy link
Member Author

panva commented Mar 7, 2023

Landed in 68e8390

panva added a commit that referenced this pull request Mar 7, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva closed this Mar 7, 2023
@panva panva deleted the update-wpt-fixtures branch March 7, 2023 10:34
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants