-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update WPT fixtures resources, common, streams, FileAPI #46912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Mar 2, 2023
panva
force-pushed
the
update-wpt-fixtures
branch
from
March 2, 2023 17:12
01fedc4
to
315dd65
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 2, 2023
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
update-wpt-fixtures
branch
from
March 2, 2023 18:51
315dd65
to
c31504f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
18 tasks
panva
force-pushed
the
update-wpt-fixtures
branch
from
March 3, 2023 08:33
c31504f
to
ed6dac4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
update-wpt-fixtures
branch
from
March 3, 2023 08:39
ed6dac4
to
c65027f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Mar 3, 2023
anonrig
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
review wanted
PRs that need reviews.
labels
Mar 3, 2023
This was referenced Mar 4, 2023
panva
force-pushed
the
update-wpt-fixtures
branch
from
March 6, 2023 14:44
c65027f
to
d89ed50
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
19 tasks
tniessen
approved these changes
Mar 7, 2023
Landed in 68e8390 |
panva
added a commit
that referenced
this pull request
Mar 7, 2023
PR-URL: #46912 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Mar 8, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46912 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46912 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
added
the
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
label
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
needs-ci
PRs that need a full CI run.
review wanted
PRs that need reviews.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled in updated testharness (resources), which prompted the update to resources, then streams, then FileAPI.
The non fixture changes are
gc
now load a specific script, when that script is detected the worker automatically loads and assigns gc to globalThisgit node wpt ...
(issue opened git node wpt only updates or creates files, doesn't remove them node-core-utils#678)webmessaging/broadcastchannel
that was missing in versions.json