Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: simplify test-tls-ecdh-multiple #46963

Merged
merged 1 commit into from
Mar 9, 2023
Merged

test: simplify test-tls-ecdh-multiple #46963

merged 1 commit into from
Mar 9, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 5, 2023

Avoid the process 'exit' event handler and use execFile instead of manual stream operations.

Refs: #46751

@tniessen tniessen added tls Issues and PRs related to the tls subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 5, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50212/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2023
This was referenced Mar 7, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50288/

@tniessen
test: simplify test-tls-ecdh-multiple
bcebb91 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: nodejs#46751
PR-URL: nodejs#46963
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@tniessen tniessen force-pushed the test-tls-ecdh-multiple-refactor branch from 520205b to bcebb91 Compare March 9, 2023 11:54
@tniessen tniessen merged commit bcebb91 into nodejs:main Mar 9, 2023
@tniessen
Copy link
Member Author

tniessen commented Mar 9, 2023

Landed in bcebb91.

targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen @targos
test: simplify test-tls-ecdh-multiple
6faded4 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46963
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@tniessen @targos
test: simplify test-tls-ecdh-multiple
5b81689 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46963
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
test: simplify test-tls-ecdh-multiple
ef6c86c 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46963
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @lpinca @anonrig @VoltrexKeyva