tools: standardize update-llhttp.sh #47198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
RafaelGSS
approved these changes
Mar 22, 2023
ShogunPanda
approved these changes
Mar 22, 2023
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47198 ✔ Done loading data for nodejs/node/pull/47198 ----------------------------------- PR info ------------------------------------ Title tools: standardize update-llhttp.sh (#47198) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/standardize-llhttp-update -> nodejs:main Labels meta, tools Commits 2 - tools: standardize update-llhttp.sh - fix: typo Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47198 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Tierney Cyren ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47198 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Tierney Cyren -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Mar 2023 17:24:29 GMT ✔ Approvals: 4 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47198#pullrequestreview-1351779806 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47198#pullrequestreview-1351979023 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47198#pullrequestreview-1353636823 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/47198#pullrequestreview-1354580951 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47198 From https://github.com/nodejs/node * branch refs/pull/47198/merge -> FETCH_HEAD ✔ Fetched commits as 06c91af1b472..60ddbed925e1 -------------------------------------------------------------------------------- Auto-merging .github/workflows/tools.yml [main 17bec4b05a] tools: standardize update-llhttp.sh Author: Marco Ippolito Date: Tue Mar 21 18:23:17 2023 +0100 4 files changed, 88 insertions(+), 73 deletions(-) create mode 100755 tools/dep_updaters/update-llhttp.sh delete mode 100755 tools/update-llhttp.sh [main d50c13703e] fix: typo Author: Marco Ippolito Date: Tue Mar 21 18:24:23 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4519237917 |
marco-ippolito
added
commit-queue-squash
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38b6ecc |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47198 Refs: nodejs/security-wg#828 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tierney Cyren <hello@bnb.im>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47198 Refs: nodejs/security-wg#828 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tierney Cyren <hello@bnb.im>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47198 Refs: nodejs/security-wg#828 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47198 Refs: nodejs/security-wg#828 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828