Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix 'partial' typo #48657

Merged
merged 1 commit into from
Jul 5, 2023
Merged

doc: fix 'partial' typo #48657

merged 1 commit into from
Jul 5, 2023

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 5, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 5, 2023
@cjihrig cjihrig requested a review from MoLow July 5, 2023 13:21
MoLow
MoLow approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsi

@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow MoLow requested a review from anonrig July 5, 2023 13:28
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit f802aa0 into main Jul 5, 2023
@nodejs-github-bot nodejs-github-bot deleted the cjihrig-patch-1 branch July 5, 2023 16:15
@nodejs-github-bot
Copy link
Collaborator

Landed in f802aa0

@juanarbol juanarbol added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 13, 2023
@juanarbol
Copy link
Member

This depends on #48656

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
doc: fix 'partial' typo
66e2e7c 
PR-URL: nodejs#48657
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
doc: fix 'partial' typo
5c5bf82 
PR-URL: nodejs#48657
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 11, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @juanarbol @lpinca @anonrig @richardlau @deokjinkim @MoLow @aymen94 @ruyadorno