deps: update undici to 5.26.0

[nodejs-github-bot]

This is an automated update of undici to 5.26.0.

[panva]

cc @nodejs/undici

[github-actions]

Failed to start CI

node:internal/modules/cjs/loader:1028
  const err = new Error(message);
              ^
Error: Cannot find module 'call-bind'

Require stack:

/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js

at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)

at Function.Module._load (node:internal/modules/cjs/loader:873:27)

at Module.require (node:internal/modules/cjs/loader:1100:19)

at require (node:internal/modules/cjs/helpers:119:18)

at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)

at Module._compile (node:internal/modules/cjs/loader:1198:14)

at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)

at Module.load (node:internal/modules/cjs/loader:1076:32)

at Function.Module._load (node:internal/modules/cjs/loader:911:12)

at ModuleWrap. (node:internal/modules/esm/translators:169:29) {

code: 'MODULE_NOT_FOUND',

requireStack: [

'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'

]

}

https://github.com/nodejs/node/actions/runs/6483457798

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54700/

[KhafraDev]

I'll take a look at the errors, seem to be related

[panva]

I'll take a look at the errors, seem to be related

It's coming from nodejs/undici#2310

[panva]

@KhafraDev @Ethan-Arrowood see the update script failing now https://github.com/nodejs/node/actions/runs/6486757082/job/17615604220#step:4:62

[KhafraDev]

maybe we do need to use esbuild hooks

[mcollina]

v5.26.2 incoming with security patch.

[panva]

please just revert the user-agent changes entirely until the build steps are figured out.

[KhafraDev]

I'll be home in an hour and a half, we won't be able to land until the esbuild issues are fixed

[Ethan-Arrowood]

its cause its missing from the files list. adding now. releasing in 5.26.3 edit its not

[mcollina]

its cause its missing from the files list. adding now. releasing in 5.26.3

No. There is a separate bug in the update script in Node, I'm opening a PR as soon as it builds.

[KhafraDev]

The script is missing that was added to build it. I thought node would pull from the undici repo, not from npm. 😕

[Ethan-Arrowood]

ty @mcollina for the assist: #50150

[panva]

I believe both nodejs/undici@5351f1f and #50150 is needed if the script insists on pulling from npm and not git.

[Ethan-Arrowood]

I already reverted my change: nodejs/undici@81e0a93 in undici. and didn't release 5.26.3.

I'll let you or Matteo take it from here. Feels like a too-many-cooks-in-the-kitchen situation.

[panva]

I'm really merely observing.

My suggestion would be to revert to the previous build step and revert the user-agent changes entirely for now. You could use typeof __filename === 'undefined' to detect the require is coming from node instead and not bother with esbuild scripts and hooks and replaces and whatnot. Pending further testing and nodejs update script proofing.