Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: support top-level await in --experimental-detect-module #50918

Closed
wants to merge 2 commits into from
Closed

src: support top-level await in --experimental-detect-module #50918

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 26, 2023

Refs: #50917

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Nov 26, 2023
@targos targos mentioned this pull request Nov 26, 2023
Closed
@targos targos marked this pull request as ready for review November 26, 2023 10:00
@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 26, 2023
@targos
Copy link
Member Author

targos commented Nov 26, 2023

c3d9ac0 Removes the problematic test. We can probably land a fix that doesn't work in all cases.

@targos
Copy link
Member Author

targos commented Nov 26, 2023 •
edited
Loading

Just saw that it was a choice not to support top-level await:

// While top-level `await` is not permitted in CommonJS, it returns the same
// error message as when `await` is used in a sync function, so we don't use it
// as a disambiguation.

@targos targos closed this Nov 26, 2023
@GeoffreyBooth
Copy link
Member

Just saw that it was a choice not to support top-level await:

Yes. Next time please tag @nodejs/loaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @GeoffreyBooth @MoLow @nodejs-github-bot