Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] perf_hooks: reduce overhead of createHistogram #51306

Closed
wants to merge 2 commits into from
Closed

[v20.x backport] perf_hooks: reduce overhead of createHistogram #51306

wants to merge 2 commits into from

Conversation

H4ad
Copy link
Member

@H4ad H4ad commented Dec 28, 2023

Backport of #50074

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Dec 28, 2023
@richardlau
Copy link
Member

This needs to be rebased.

@H4ad
perf_hooks: reduce overhead of createHistogram
1963511 
PR-URL: nodejs#50074
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Backport-PR-URL: nodejs#50074
@H4ad
test: avoid v8 deadcode on performance function
e89f702 
PR-URL: nodejs#50074
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Backport-PR-URL: nodejs#50074
@H4ad H4ad requested a review from richardlau March 25, 2024 21:35
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57950/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57953/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57955/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57978/

richardlau pushed a commit that referenced this pull request Mar 28, 2024
@H4ad @richardlau
perf_hooks: reduce overhead of createHistogram
1daccf5 
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau pushed a commit that referenced this pull request Mar 28, 2024
@H4ad @richardlau
test: avoid v8 deadcode on performance function
5ff73f3 
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@richardlau
Copy link
Member

Landed in 025ba26...5ff73f3.

@richardlau richardlau closed this Mar 28, 2024
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@H4ad @marco-ippolito
perf_hooks: reduce overhead of createHistogram
512ca44 
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@H4ad @marco-ippolito
test: avoid v8 deadcode on performance function
235622f 
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon Awaiting requested review from UlisesGascon

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@H4ad @richardlau @nodejs-github-bot