-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: call out http(s).globalAgent defaults #52392
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
fahrradflucht:docs/http-global-agent-defaults
Apr 8, 2024
Merged
doc: call out http(s).globalAgent defaults #52392
nodejs-github-bot
merged 1 commit into
nodejs:main
from
fahrradflucht:docs/http-global-agent-defaults
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
lpinca
approved these changes
Apr 7, 2024
Closes: #51115 |
ShogunPanda
approved these changes
Apr 7, 2024
mcollina
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Despite the `http.Agent` stating: > The default `http.globalAgent` that is used by `http.request()` has > all of these values set to their respective defaults. this isn't true anymore since node.js 19. Both, the http as well as the https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo', timeout: 5000 }` as options. `'lifo'` is the default anyway, but `keepAlive` is turned off and no `timeout` is set on `new Agent()`. Document the diverging behaviour in the `globalAgent` sections, remove the false statement from `http.Agent` section, and extend the changelog to call out the timeout change as well.
fahrradflucht
force-pushed
the
docs/http-global-agent-defaults
branch
from
April 7, 2024 08:45
f477d6d
to
4a008be
Compare
Fixed the commit message. 🙄 Never make an edit without |
marco-ippolito
approved these changes
Apr 7, 2024
UlisesGascon
approved these changes
Apr 7, 2024
"lint-js-and-md" failure looks like CI flake to me. |
MoLow
approved these changes
Apr 8, 2024
marco-ippolito
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 8, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 8, 2024
Landed in 655b327 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Despite the `http.Agent` stating: > The default `http.globalAgent` that is used by `http.request()` has > all of these values set to their respective defaults. this isn't true anymore since node.js 19. Both, the http as well as the https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo', timeout: 5000 }` as options. `'lifo'` is the default anyway, but `keepAlive` is turned off and no `timeout` is set on `new Agent()`. Document the diverging behaviour in the `globalAgent` sections, remove the false statement from `http.Agent` section, and extend the changelog to call out the timeout change as well. PR-URL: #52392 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Despite the `http.Agent` stating: > The default `http.globalAgent` that is used by `http.request()` has > all of these values set to their respective defaults. this isn't true anymore since node.js 19. Both, the http as well as the https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo', timeout: 5000 }` as options. `'lifo'` is the default anyway, but `keepAlive` is turned off and no `timeout` is set on `new Agent()`. Document the diverging behaviour in the `globalAgent` sections, remove the false statement from `http.Agent` section, and extend the changelog to call out the timeout change as well. PR-URL: #52392 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the
http.Agent
stating:this isn't true anymore since node.js 19. Both, the http and the https
globalAgent
now set{ keepAlive: true, scheduling: 'lifo', timeout: 5000 }
as options.'lifo'
is the default anyway, butkeepAlive
is turned off and notimeout
is set onnew Agent()
.Document the diverging behavior in the
globalAgent
sections, remove the false statement fromhttp.Agent
section, and extend the changelog to call out the timeout change as well.Closes #48821
Closes #51115