Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 12.4 #52465

Closed
wants to merge 15 commits into from
Closed

deps: update V8 to 12.4 #52465

wants to merge 15 commits into from

Commits on Apr 19, 2024

  1. deps: update V8 to 12.4.254.14

    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d887f85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4c6f08 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 127

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 12.4.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8d1bbf8 View commit details
    Browse the repository at this point in the history
  4. deps: always define V8_EXPORT_PRIVATE as no-op

    dllexport introduces issues when compiling with MSVC.
    
    PR-URL: nodejs#47251
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    88a4285 View commit details
    Browse the repository at this point in the history
  5. deps: silence irrelevant V8 warning

    PR-URL: nodejs#45579
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a41d78c View commit details
    Browse the repository at this point in the history
  6. deps: disable V8 concurrent sparkplug compilation

    It introduces process hangs on some platforms because Node.js doesn't
    tear down V8 correctly.
    Disable it while we work on a solution.
    
    Refs: nodejs#47297
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
    PR-URL: nodejs#47450
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1999abf View commit details
    Browse the repository at this point in the history
  7. deps: avoid compilation error with ASan

    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6be9104 View commit details
    Browse the repository at this point in the history
  8. deps: remove usage of a C++20 feature from V8

    We are not ready to compile with C++20 support yet.
    This is only a DCHECK that can be removed without affecting the behavior
    of release builds.
    
    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    915255b View commit details
    Browse the repository at this point in the history
  9. deps: patch V8 to avoid duplicated zlib symbol

    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c09d25f View commit details
    Browse the repository at this point in the history
  10. deps: silence internal V8 deprecation warning

    PR-URL: nodejs#52293
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2aa1874 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. build: compile with C++20 support on Windows

    Our Linux build infra is not ready for it yet,
    but V8 is making it difficult to compile on Windows
    without it.
    
    Refs: nodejs#45402
    StefanStojanovic authored and targos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    486bbc8 View commit details
    Browse the repository at this point in the history
  2. deps: patch V8 to support compilation with MSVC

    After enabling -std:c++20 on Windows, patch is now much smaller.
    StefanStojanovic authored and targos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    55deada View commit details
    Browse the repository at this point in the history
  3. deps: V8: revert CL 5331688

    On Windows debug builds, it is not allowed to dereference empty
    iterators.
    
    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
    targos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e5a2b47 View commit details
    Browse the repository at this point in the history
  4. deps: V8: cherry-pick cd10ad7cdbe5

    Original commit message:
    
        [compiler] reset script details in functions deserialized from code cache
    
        During the serialization of the code cache, V8 would wipe out the
        host-defined options, so after a script id deserialized from the
        code cache, the host-defined options need to be reset on the script
        using what's provided by the embedder when doing the deserializing
        compilation, otherwise the HostImportModuleDynamically callbacks
        can't get the data it needs to implement dynamic import().
    
        Change-Id: I33cc6a5e43b6469d3527242e083f7ae6d8ed0c6a
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5401780
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Joyee Cheung <joyee@igalia.com>
        Cr-Commit-Position: refs/heads/main@{#93323}
    
    Refs: v8/v8@cd10ad7
    PR-URL: nodejs#52535
    Refs: nodejs#47472
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    joyeecheung authored and targos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5d0cc1b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9c7011 View commit details
    Browse the repository at this point in the history