Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct typescript stdin support #54036

Merged
merged 1 commit into from
Jul 25, 2024
Merged

doc: correct typescript stdin support #54036

merged 1 commit into from
Jul 25, 2024

Conversation

marco-ippolito
Copy link
Member

STDIN was never meant to be supported initally, so the documentation is incorrect.

Fixes: #54035

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 25, 2024
@marco-ippolito marco-ippolito added strip-types Issues or PRs related to strip-types support fast-track PRs that do not need to wait for 48 hours to land. and removed doc Issues and PRs related to the documentations. labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

@marco-ippolito
Copy link
Member Author

we definitely need to add this doc under some codeowner cc @nodejs/loaders

GeoffreyBooth
GeoffreyBooth approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but why would it work for eval and not STDIN? We usually treat those as equivalent.

@marco-ippolito
Copy link
Member Author

Fine, but why would it work for eval and not STDIN? We usually treat those as equivalent.

It has not been implemented or tested, it has to be done, so pr welcome 😆

mcollina
mcollina approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2cd9687 into nodejs:main Jul 25, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2cd9687

targos pushed a commit that referenced this pull request Jul 28, 2024
@marco-ippolito @targos
doc: correct typescript stdin support
63d6cc1 
PR-URL: #54036
Fixes: #54035
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@marco-ippolito @RafaelGSS
doc: correct typescript stdin support
c1634c7 
PR-URL: #54036
Fixes: #54035
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--experimental-strip-types does not work for STDIN
6 participants
@marco-ippolito @nodejs-github-bot @mcollina @GeoffreyBooth @anonrig @targos