doc: add more info to benchmark/README.md #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
LGTM. Good addition. |
|
LGTM |
Adds info on the `wrk` prerequisite for http benchmarks and how to run benchmarks with options. PR-URL: nodejs#629 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
Fishrock123
force-pushed
the
benchmark-docs
branch
from
4ba46c0
to
514b1d9
Compare
|
@Fishrock123 Can you |
|
@bnoordhuis you mean to my real name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds info on the
wrkprerequisite for http benchmarks and how to run benchmarks with options.I ran into both of these things trying to run benchmarks today.
R=@bnoordhuis?