-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add guides to (navigational) _toc.md #6522
doc: add guides to (navigational) _toc.md #6522
Conversation
This effectivetly gives the guides a home for users to naviagte to the guides from the reference
@@ -0,0 +1,39 @@ | |||
# Building Node with Ninja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git mv the one file that was already there into some sort of file structure
Might be better to not impose the directory structure part of categorization. I think it's likely things will move in the future, or topics will come up that fit many categories. |
ping @eljefedelrodeodeljefe ... what's the status on this? |
@eljefedelrodeodeljefe @Fishrock123 do we want the guides to live in the API docs? In that case, we should consider moving these over too: https://github.com/nodejs/nodejs.org/tree/master/locale/en/docs/guides |
The guides belong(ed) here but the build steps necessary were never completed. |
Thanks @Fishrock123. @eljefedelrodeodeljefe - if I can find some time, do you mind if I work on this? |
c133999
to
83c7a88
Compare
Be my guest. If you don't it will be okay too. I should make a broader proposal for getting this in though and will try to force me working on this the coming weekend. |
@@ -0,0 +1,39 @@ | |||
# Building Node with Ninja | |||
|
|||
The purpose of this guide is to show how to build Node.js using [Ninja][], as doing so can be significantly quicker than using `make`. Please see [Ninja's site][Ninja] for installation instructions (unix only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long line
Related: #10792 |
Ping @eljefedelrodeodeljefe ... still want to pursue this? |
Will check (after now having moved the guides) and possibly merge tomorrow, if there are no objections. Sorry for my lack of time @jasnell and thanks for pining |
Closing due to a long inactivity. @eljefedelrodeodeljefe please feel free to reopen if you want to follow up on this. |
DO NOT MERGE
Checklist
Affected core subsystem(s)
doc
Description of change
This effectivetly gives the guides a home for users to naviagte
to the guides from the reference.
It's a little early because of #5408, but we would need to have the discussion asap to put the guides somewhere. Also the home of guides needs to have an own toc, structure and index.html.
cc @nodejs/documentation and @jasnell probably has a good opinion on this, if you like.