New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: workaround clang-3.4 ICE #8343

Merged
merged 1 commit into from Aug 31, 2016

Conversation

Projects
None yet
4 participants
@ofrobots
Contributor

ofrobots commented Aug 30, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps: v8

Description of change

Work around internal compiler error with clang-3.4.

R=@nodejs/v8
/cc @chrislea
Fixes: #8323

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3893/
EDIT: V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/293/

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 30, 2016

Contributor

Is there already an upstream bug fix or at least an upstream issue for this that might be worth linking to also?

Contributor

mscdex commented Aug 30, 2016

Is there already an upstream bug fix or at least an upstream issue for this that might be worth linking to also?

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 30, 2016

Contributor

I don't have an upstream bug fix link, but the issue seems to be fixed in clang-3.4.2. As per #8323 (comment), it is non-trivial to upgrade to clang-3.4.2 or newer on the wheezy & precise configurations.

Contributor

ofrobots commented Aug 30, 2016

I don't have an upstream bug fix link, but the issue seems to be fixed in clang-3.4.2. As per #8323 (comment), it is non-trivial to upgrade to clang-3.4.2 or newer on the wheezy & precise configurations.

@ofrobots ofrobots referenced this pull request Aug 31, 2016

Closed

inspector: Simplify buffer management #8257

2 of 2 tasks complete
@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Aug 31, 2016

Member

Aside from objecting to the ugliness of C++, this LGTM

Green CI run @ https://ci.nodejs.org/job/node-test-commit/4862/

Most notably, clang 3.4.1 run @ https://ci.nodejs.org/job/node-test-commit-linux/4917/nodes=ubuntu1204-clang341-64/

Member

rvagg commented Aug 31, 2016

Aside from objecting to the ugliness of C++, this LGTM

Green CI run @ https://ci.nodejs.org/job/node-test-commit/4862/

Most notably, clang 3.4.1 run @ https://ci.nodejs.org/job/node-test-commit-linux/4917/nodes=ubuntu1204-clang341-64/

@ofrobots ofrobots changed the base branch from v6.x to master Aug 31, 2016

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 31, 2016

Contributor

I have retargeted this PR to master (from v6.x) now that we have a (broken) CI builder for clang-3.4.

New CI: https://ci.nodejs.org/job/node-test-pull-request/3911/

Contributor

ofrobots commented Aug 31, 2016

I have retargeted this PR to master (from v6.x) now that we have a (broken) CI builder for clang-3.4.

New CI: https://ci.nodejs.org/job/node-test-pull-request/3911/

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Aug 31, 2016

Member

CI is green (enough). Debian8 failure is Jenkins, I've updated and restarted that node. OSX failure is known flaky (#4629). clang 4.3.1 is 👍

lgtm still

Member

rvagg commented Aug 31, 2016

CI is green (enough). Debian8 failure is Jenkins, I've updated and restarted that node. OSX failure is known flaky (#4629). clang 4.3.1 is 👍

lgtm still

deps: workaround clang-3.4 ICE
PR-URL: #8343
Fixes: #8323
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

@ofrobots ofrobots merged commit 870faee into nodejs:master Aug 31, 2016

1 check passed

test/aix all tests passed
Details
@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots

ofrobots Aug 31, 2016

Contributor

Thanks landed as 870faee.

Contributor

ofrobots commented Aug 31, 2016

Thanks landed as 870faee.

@ofrobots ofrobots deleted the ofrobots:workaround-for-clang-3.4 branch Aug 31, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

deps: workaround clang-3.4 ICE
PR-URL: nodejs#8343
Fixes: nodejs#8323
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

deps: workaround clang-3.4 ICE
PR-URL: #8343
Fixes: #8323
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

@bnoordhuis bnoordhuis referenced this pull request Sep 12, 2016

Merged

deps: update V8 to 5.4 #8317

2 of 2 tasks complete

ofrobots added a commit to ofrobots/node that referenced this pull request Sep 12, 2016

targos added a commit to targos/node that referenced this pull request Sep 22, 2016

deps: cherry-pick workaround for clang-3.4 ICE
Ref: nodejs#8343
Fixes: nodejs#8323

PR-URL: nodejs#8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

jasnell added a commit that referenced this pull request Sep 29, 2016

deps: cherry-pick workaround for clang-3.4 ICE
Ref: #8343
Fixes: #8323

PR-URL: #8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

targos added a commit to targos/node that referenced this pull request Dec 30, 2016

deps: cherry-pick workaround for clang-3.4 ICE
Ref: nodejs#8343
Fixes: nodejs#8323

PR-URL: nodejs#8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request Feb 1, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Ref: nodejs#8343
Fixes: nodejs#8323

PR-URL: nodejs#8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

targos added a commit to targos/node that referenced this pull request Feb 7, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Fixes: nodejs#8323
Refs: nodejs#8343
Refs: nodejs#8317

PR-URL: nodejs#11029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Fixes: nodejs#8323
Refs: nodejs#8343
Refs: nodejs#8317

PR-URL: nodejs#11029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@targos targos referenced this pull request Mar 29, 2017

Closed

deps: update V8 to 5.5 #9618

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment