Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
deps: update V8 to 5.5 #9618
Affected core subsystem(s)
Description of change
This PR updates V8 to the current
Previous discussion: nodejs/v8#2
CI run to validate across platforms: https://ci.nodejs.org/job/node-test-commit-v8-linux/421/
This was referenced
Nov 21, 2016
test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffd\ufffdA'); // AssertionError: Expected "\ufffd\ufffd\u41", but got "\ufffd\u41"
If I change the expected value, the error is inverted:
test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffdA'); // AssertionError: Expected "\ufffd\u41", but got "\ufffd\ufffd\u41"
@targos trying to summarize current status. Let me know if anything is incorrect.
Others: let's keep the focus of this issue on landing V8 5.5 onto
CI run after change to job to not run on smartos14 if version is 8 or higher: https://ci.nodejs.org/job/node-test-pull-request/6052/
added a commit
this pull request
Jan 26, 2017
CI run one more time: https://ci.nodejs.org/job/node-test-pull-request/6073/