New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: favor `===` over in `==` in http test #8471

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@jun-oka
Contributor

jun-oka commented Sep 9, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

Description of change
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 9, 2016

Member

LGTM, thank you! :) By the way, your author name in this commit is given as “jun-oka”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

Member

addaleax commented Sep 9, 2016

LGTM, thank you! :) By the way, your author name in this commit is given as “jun-oka”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 9, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 9, 2016

LGTM

@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 9, 2016

Contributor

@addaleax Thank you for that info! In that case, I prefer to use "Junshu Okamoto".

Contributor

jun-oka commented Sep 9, 2016

@addaleax Thank you for that info! In that case, I prefer to use "Junshu Okamoto".

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 9, 2016

Member

@jun-oka I guess @Trott is around somewhere and can help you, but usually, you can update the commit here yourself. It goes something like this:

git config --global user.name 'Junshu Okamoto' # (leave out the --global if you only want this for Node)
git commit --amend --reset-author
git push --force-with-lease

(git magic! 😄)

Member

addaleax commented Sep 9, 2016

@jun-oka I guess @Trott is around somewhere and can help you, but usually, you can update the commit here yourself. It goes something like this:

git config --global user.name 'Junshu Okamoto' # (leave out the --global if you only want this for Node)
git commit --amend --reset-author
git push --force-with-lease

(git magic! 😄)

@Trott

View changes

Show outdated Hide outdated test/parallel/test-http.js
@@ -10,7 +10,7 @@ var body0 = '';
var body1 = '';
var server = http.Server(function(req, res) {
if (responses_sent == 0) {
if (responses_sent === 0) {
assert.equal('GET', req.method);

This comment has been minimized.

@Trott

Trott Sep 9, 2016

Member

Can you update assert.equal() here and elsewhere to use assert.strictEqual() instead? Might as well get all our minor refactoring in at once. :-D

@Trott

Trott Sep 9, 2016

Member

Can you update assert.equal() here and elsewhere to use assert.strictEqual() instead? Might as well get all our minor refactoring in at once. :-D

@Trott

View changes

Show outdated Hide outdated test/parallel/test-http.js
@@ -10,7 +10,7 @@ var body0 = '';
var body1 = '';
var server = http.Server(function(req, res) {

This comment has been minimized.

@Trott

Trott Sep 9, 2016

Member

This var and some (but not all) of the others can be changed to const.

@Trott

Trott Sep 9, 2016

Member

This var and some (but not all) of the others can be changed to const.

@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 9, 2016

Contributor

@addaleax Yes! @Trott is next to me.
@Trott OK. Thank you.

Contributor

jun-oka commented Sep 9, 2016

@addaleax Yes! @Trott is next to me.
@Trott OK. Thank you.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 9, 2016

Member

LGTM if CI doesn't reveal any surprises.

Member

Trott commented Sep 9, 2016

LGTM if CI doesn't reveal any surprises.

@Trott

This comment has been minimized.

Show comment
Hide comment
@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 9, 2016

Contributor

It seems unrelated error, I hope.

Contributor

jun-oka commented Sep 9, 2016

It seems unrelated error, I hope.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 10, 2016

Member

The ubuntu1404-32 failure is unrelated and I think the arm one is expected.
LGTM.

Member

lpinca commented Sep 10, 2016

The ubuntu1404-32 failure is unrelated and I think the arm one is expected.
LGTM.

if (responses_sent == 0) {
assert.equal('GET', req.method);
assert.equal('/hello', url.parse(req.url).pathname);
const server = http.Server(function(req, res) {

This comment has been minimized.

@thefourtheye

thefourtheye Sep 10, 2016

Contributor

Now that you are doing this, why don't you change the requires as well.

@thefourtheye

thefourtheye Sep 10, 2016

Contributor

Now that you are doing this, why don't you change the requires as well.

This comment has been minimized.

@jun-oka

jun-oka Sep 10, 2016

Contributor

@thefourtheye That's right. Let me do that.

@jun-oka

jun-oka Sep 10, 2016

Contributor

@thefourtheye That's right. Let me do that.

This comment has been minimized.

@jun-oka

jun-oka Sep 12, 2016

Contributor

@thefourtheye I will finish it today.

@jun-oka

jun-oka Sep 12, 2016

Contributor

@thefourtheye I will finish it today.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

LGTM

Member

jasnell commented Sep 12, 2016

LGTM

@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 13, 2016

Contributor

I updated :)

Contributor

jun-oka commented Sep 13, 2016

I updated :)

@Trott

This comment has been minimized.

Show comment
Hide comment
@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 13, 2016

Contributor

Hmm error again.

Contributor

jun-oka commented Sep 13, 2016

Hmm error again.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 13, 2016

Member

Errors in CI are unrelated build issues and one known flaky.

Member

Trott commented Sep 13, 2016

Errors in CI are unrelated build issues and one known flaky.

Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: nodejs#8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 13, 2016

Member

Landed in 7f2c9ba

Member

Trott commented Sep 13, 2016

Landed in 7f2c9ba

@Trott Trott closed this Sep 13, 2016

@jun-oka

This comment has been minimized.

Show comment
Hide comment
@jun-oka

jun-oka Sep 13, 2016

Contributor

Thank you Trott

Contributor

jun-oka commented Sep 13, 2016

Thank you Trott

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 6, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: refector parallel/test-http.js
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment