New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: fix TypeError in v8-polyfill #8863

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@geek
Member

geek commented Sep 30, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8 profile processor

Description of change

readline() can return a boolean, in which case, line 90 will throw an exception. This change addresses the issue by defaulting to a string in readline() instead of returning false.

@mscdex mscdex added process and removed tools labels Sep 30, 2016

@targos

targos approved these changes Sep 30, 2016

@jasnell

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

I'd change the return false in readline() to return '', that way future call sites won't run into the same issue.

If other collaborators think this is fine though, I'm fine with it too.

@geek

This comment has been minimized.

Show comment
Hide comment
@geek
Member

geek commented Oct 4, 2016

@bnoordhuis fixed

@targos

targos approved these changes Oct 4, 2016

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@geek

This comment has been minimized.

Show comment
Hide comment
@geek

geek Oct 5, 2016

Member

This was the failure on AIX

https://ci.nodejs.org/job/node-test-commit-aix/1300/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1219 pseudo-tty/test-tty-wrap

I reran the job and it succeeded:

https://ci.nodejs.org/job/node-test-commit-aix/1305/

Member

geek commented Oct 5, 2016

This was the failure on AIX

https://ci.nodejs.org/job/node-test-commit-aix/1300/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1219 pseudo-tty/test-tty-wrap

I reran the job and it succeeded:

https://ci.nodejs.org/job/node-test-commit-aix/1305/

jasnell added a commit that referenced this pull request Oct 6, 2016

lib: fix TypeError in v8-polyfill
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 6, 2016

Member

Landed in 47d1588

Member

jasnell commented Oct 6, 2016

Landed in 47d1588

@jasnell jasnell closed this Oct 6, 2016

@geek geek deleted the geek:fix-v8-polyfill branch Oct 6, 2016

jasnell added a commit that referenced this pull request Oct 6, 2016

lib: fix TypeError in v8-polyfill
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Oct 6, 2016

Member

added lts watch as this lands on v4.x let me know if it should not land

Member

MylesBorins commented Oct 6, 2016

added lts watch as this lands on v4.x let me know if it should not land

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 7, 2016

Member

there's likely no harm in landing it.

Member

jasnell commented Oct 7, 2016

there's likely no harm in landing it.

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

lib: fix TypeError in v8-polyfill
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 18, 2016

lib: fix TypeError in v8-polyfill
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v4.7.0 proposal #9736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment