Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo rval to value #9023

Closed
wants to merge 1 commit into from
Closed

src: fix typo rval to value #9023

wants to merge 1 commit into from

Conversation

maasencioh
Copy link
Contributor

@maasencioh maasencioh commented Oct 11, 2016 •
edited
Loading

Checklist
  • commit message follows commit guidelines
Description of change

rval never existed, it was added as that in 077f9d7

closes #9001

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 11, 2016
@gibfahn
Copy link
Member

gibfahn commented Oct 11, 2016

cc/ @fhinkel

@fhinkel
Copy link
Member

fhinkel commented Oct 11, 2016 •
edited
Loading

Thanks! LGTM.
Small change though please: Can you use the full URL of the issue in the commit message please.

@maasencioh
Copy link
Contributor Author

Hello @fhinkel it's done 😸

@lpinca
Copy link
Member

lpinca commented Oct 11, 2016

@maasencioh can you please use Fixes: as specified in CONTRIBUTING.md:

Fixes: https://github.com/nodejs/node/issues/9001

Thanks.

@maasencioh
src: fix typo rval to value
2153f66 
rval never existed, it was added as that in 077f9d7

Fixes: nodejs#9001
@maasencioh
Copy link
Contributor Author

@lpinca thanks, I just did it

lpinca
lpinca approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is trivial enough not to wait the full 48 hours

jasnell pushed a commit that referenced this pull request Oct 11, 2016
@maasencioh @jasnell
src: fix typo rval to value
88323e8 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 11, 2016

Landed in 88323e8

@jasnell jasnell closed this Oct 11, 2016
@maasencioh maasencioh deleted the patch-1 branch October 11, 2016 19:09
jasnell pushed a commit that referenced this pull request Oct 12, 2016
@maasencioh @jasnell
src: fix typo rval to value
e175188 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@maasencioh
src: fix typo rval to value
0e37a6a 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@maasencioh
src: fix typo rval to value
f669a08 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Nov 22, 2016
Merged
Merged
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated variable name in comment