New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enable ES2016 support in ESLint #9218

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
7 participants
@targos
Member

targos commented Oct 21, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

This allows to use the exponentiation operator.

Ref: #9208 (comment)

@targos targos added the tools label Oct 21, 2016

@targos targos referenced this pull request Oct 21, 2016

Merged

test: add child_process.exec() timeout coverage #9208

3 of 3 tasks complete
@thefourtheye

Should we consider performance implications of the new features before allowing us to use this?

@targos

This comment has been minimized.

Member

targos commented Oct 21, 2016

@thefourtheye you're right. Though I would be surprised if V8 didn't just convert this operator to a Math.pow call.
/cc @nodejs/v8

@thefourtheye

This comment has been minimized.

Contributor

thefourtheye commented Oct 21, 2016

@targos Looks like, in ** case, it is internally translated to Math.pow call only, if I am not wrong. https://codereview.chromium.org/1678303002/diff/320001/src/parsing/parser.cc?context=10&column_width=80&tab_spaces=8

@targos

This comment has been minimized.

Member

targos commented Oct 24, 2016

@targos

This comment has been minimized.

Member

targos commented Oct 24, 2016

@thefourtheye LGTY ?

@thefourtheye

This comment has been minimized.

Contributor

thefourtheye commented Oct 24, 2016

@targos What about the other features in es2016? Do we have any rough idea if they will also be performing at par with their es2015 equivalents? Because once we allow them in the linter it means that we officially allow es2016 in our codebase.

@lpinca

lpinca approved these changes Oct 24, 2016

@targos

This comment has been minimized.

Member

targos commented Oct 24, 2016

The exponentiation operator is the only new syntax of ES2016. This change doesn't add support for other features.

.eslintrc Outdated
@@ -1,6 +1,8 @@
env:
node: true
es6: true
parserOptions:

This comment has been minimized.

@lpinca

lpinca Oct 24, 2016

Member

Nit: what about adding a blank line before this one?

This comment has been minimized.

@targos

targos Oct 24, 2016

Member

Ack. I'll do it on merge

@targos

This comment has been minimized.

Member

targos commented Oct 24, 2016

Maybe I can change the commit message to tools: enable ES2016 syntax support in ESLint to make it clearer.

tools: enable ES2016 syntax support in ESLint
This allows us to use the exponentiation operator.

PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@targos targos force-pushed the targos:eslint-es2016 branch to 6031d8e Oct 24, 2016

@targos

This comment has been minimized.

Member

targos commented Oct 24, 2016

Landed in 6031d8e

@targos targos closed this Oct 24, 2016

@targos targos deleted the targos:eslint-es2016 branch Oct 24, 2016

@targos targos merged commit 6031d8e into nodejs:master Oct 24, 2016

jasnell added a commit that referenced this pull request Oct 24, 2016

tools: enable ES2016 syntax support in ESLint
This allows us to use the exponentiation operator.

PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 17, 2016

tools: enable ES2016 syntax support in ESLint
This allows us to use the exponentiation operator.

PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 19, 2016

tools: enable ES2016 syntax support in ESLint
This allows us to use the exponentiation operator.

PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment