Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: clean up program/isolate/env init logic #9224

Merged
merged 2 commits into from Oct 24, 2016

Conversation

@bnoordhuis
Copy link
Member

commented Oct 21, 2016

General cleanup:

  1. Shuffle around the startup sequence so it's less a ball of twine, and
  2. Remove the unnecessary NodeInstance class.
@jasnell
Copy link
Member

left a comment

LGTM with green CI

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Oct 22, 2016

I started the CI yesterday but it doesn't show up. New run: https://ci.nodejs.org/job/node-test-pull-request/4618/

@jasnell

This comment has been minimized.

Copy link
Member

commented Oct 22, 2016

Some red there but they appear to be unrelated.

bnoordhuis added 2 commits Oct 21, 2016
src: simplify code, remove NodeInstanceData
NodeInstanceData is not used meaningfully and makes the initialization
logic harder to follow.  Let's remove it and delete 100 lines of code
in one fell swoop.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>
src: clean up program/isolate/env init logic
Reorder the initialization logic so that program-wide, per-isolate and
per-environment initialization is more cleanly separated.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis force-pushed the bnoordhuis:simplify-startup branch to ceb6023 Oct 24, 2016

@bnoordhuis bnoordhuis closed this Oct 24, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:simplify-startup branch Oct 24, 2016

@bnoordhuis bnoordhuis merged commit ceb6023 into nodejs:master Oct 24, 2016

evanlucas added a commit that referenced this pull request Nov 2, 2016
src: simplify code, remove NodeInstanceData
NodeInstanceData is not used meaningfully and makes the initialization
logic harder to follow.  Let's remove it and delete 100 lines of code
in one fell swoop.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this pull request Nov 2, 2016
src: clean up program/isolate/env init logic
Reorder the initialization logic so that program-wide, per-isolate and
per-environment initialization is more cleanly separated.

PR-URL: #9224
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

@bnoordhuis should this be backported? I'm assuming it shouldn't land on v4. It does not land cleanly on v6. Please feel free to update labels

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Nov 18, 2016

Back-porting isn't necessary unless it causes conflicts for other pull requests. Let me know if that is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.