Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: typo in util.inherits documentation for ES6 example #9737

Closed
wants to merge 1 commit into from
Closed

doc: typo in util.inherits documentation for ES6 example #9737

wants to merge 1 commit into from

Conversation

bankyadam
Copy link

@bankyadam bankyadam commented Nov 22, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

there is no need for "util" in the ES6 example

@mscdex mscdex mentioned this pull request Nov 22, 2016
Closed
@mscdex mscdex added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Nov 22, 2016
@silverwind
Copy link
Contributor

Thanks! Landed in aa1333f.

@silverwind silverwind closed this Nov 23, 2016
silverwind pushed a commit that referenced this pull request Nov 23, 2016
@silverwind
doc: "util" is not needed to extend ES6 classes
aa1333f 
PR-URL: #9737
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@addaleax
doc: "util" is not needed to extend ES6 classes
65af114 
PR-URL: #9737
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
doc: "util" is not needed to extend ES6 classes
1c9817c 
PR-URL: #9737
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
doc: "util" is not needed to extend ES6 classes
103b9fc 
PR-URL: #9737
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@italoacasas italoacasas italoacasas approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bankyadam @silverwind @lpinca @cjihrig @italoacasas @mscdex @MylesBorins