nina 2016 code-n-learn, issue: use assert.Equal() #9977
Conversation
|
@ianwhitedeveloper May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
imyller
added
the
code-and-learn
ianwhitedeveloper
force-pushed
the
use-assert-equal
branch
from
dbd6e32
to
76f28a8
Compare
|
Alrighty just pushed an amended commit. Thanks again. |
|
@ianwhitedeveloper Looks great! Thank you 👍 |
|
@ianwhitedeveloper FYI, your commit has the name git commit --amend --no-edit --author="Ian White <ian.white.developer@gmail.com>"And then update your branch (which will update this PR). |
| @@ -34,7 +34,7 @@ fs.appendFileSync(filename2, data); | |||
|
|
|||
| var fileData2 = fs.readFileSync(filename2); | |||
|
|
|||
| assert.equal(Buffer.byteLength(data) + currentFileData.length, | |||
| assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, | |||
| fileData2.length); | |||
There was a problem hiding this comment.
This needs to be lined up now.
| } | ||
|
|
||
| var fileData4 = fs.readFileSync(filename4); | ||
|
|
||
| assert.equal(Buffer.byteLength('' + num) + currentFileData.length, | ||
| assert.strictEqual(Buffer.byteLength('' + num) + currentFileData.length, | ||
| fileData4.length); |
| @@ -76,7 +76,7 @@ fs.closeSync(filename5fd); | |||
|
|
|||
| var fileData5 = fs.readFileSync(filename5); | |||
|
|
|||
| assert.equal(Buffer.byteLength(data) + currentFileData.length, | |||
| assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, | |||
| fileData5.length); | |||
|
Alrighty @cjihrig I'll make those updates ASAP. Having problems with my computer so I'm going to need to clear a bunch of space to get the project up and running, but it's on my radar! thanks for taking a look. |
|
Ok @cjihrig I made the changes. Hopefully I didn't misunderstand the problem! Thanks again! |
Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 62f4b77. Thanks for the contribution! 🎉 |
Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Test
Description of change
test: change
assert.equaltoassert.strictEqualthe following lines have been updated: