Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

Fix various HTML and JS issues #155

Merged
merged 5 commits into from
Jul 18, 2015
Merged

Fix various HTML and JS issues #155

merged 5 commits into from
Jul 18, 2015

Conversation

fhemberger
Copy link
Contributor

@nodejs/website please review.

@robertkowalski
Copy link
Contributor

+1

I also noticed the href error yesterday that happens because of the template copy&paste and had a patch for it unstaged - but these collection of fixes is super awesome!

Btw (just got reminded of it):

I think the only reason why the template copy&paste started (long before our time) is that the navigation on the left needs different elements (if the submenu is opened) with highlighted elements. The copy & paste almost leads to errors for every new page that is created, which are catched sometimes during the review (and sometimes not). Even when they are catched they cost time.

I started a disussion about a dynamic navigation some time ago nodejs/nodejs.org#81 but I am not sure if we should spend a lot of time for nodejs.org with refactorings if we work on new.nodejs.org soon anyway... thoughts - opinions?

@fhemberger
Copy link
Contributor Author

but I am not sure if we should spend a lot of time for nodejs.org with refactorings if we work on new.nodejs.org soon anyway...

It's the same for iojs.org … I'd still ship updates and bugfixes but wouldn't invest too much time on new features or refactorings. Better focus our attention on the new website.

fhemberger added a commit that referenced this pull request Jul 18, 2015
Fix various HTML and JS issues
@fhemberger fhemberger merged commit 45d8ee0 into master Jul 18, 2015
@fhemberger fhemberger deleted the fix/html-js branch July 18, 2015 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants