Skip to content

Commit

Permalink
Revert "meta: switch v6.x to LTS (#973)"
Browse files Browse the repository at this point in the history
For the release of v7.0 we should revert commit 8c53b4b

This can be trumped by #990 if it is ready for release before v7 is cut
  • Loading branch information
MylesBorins authored and jasnell committed Oct 25, 2016
1 parent 0a5d542 commit 14805d5
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 11 deletions.
6 changes: 3 additions & 3 deletions locale/en/download/current.md
Expand Up @@ -4,14 +4,14 @@ title: Download
download: Download
downloads:
headline: Downloads
lts: LTS v4.x
current: LTS v6.x
lts: LTS
current: Current
tagline-current: Latest Features
tagline-lts: Recommended For Most Users
display-hint: Display downloads for
intro: >
Download the Node.js source code or a pre-built installer for your platform, and start developing today.
currentVersion: LTS Version
currentVersion: Latest Current Version
buildDisclaimer: "Note: Python 2.6 or 2.7 is required to build from source tarballs."
additional:
headline: Additional Platforms
Expand Down
6 changes: 3 additions & 3 deletions locale/en/download/index.md
Expand Up @@ -4,14 +4,14 @@ title: Download
download: Download
downloads:
headline: Downloads
lts: LTS v4.x
current: LTS v6.x
lts: LTS
current: Current
tagline-current: Latest Features
tagline-lts: Recommended For Most Users
display-hint: Display downloads for
intro: >
Download the Node.js source code or a pre-built installer for your platform, and start developing today.
currentVersion: LTS Version
currentVersion: Latest LTS Version
buildDisclaimer: "Note: Python 2.6 or 2.7 is required to build from source tarballs."
additional:
headline: Additional Platforms
Expand Down
4 changes: 2 additions & 2 deletions locale/en/index.md
@@ -1,13 +1,13 @@
---
layout: index.hbs
labels:
current-version: LTS
current-version: Current Version
download: Download
download-for: Download for
other-downloads: Other Downloads
other-lts-downloads: Other LTS Downloads
other-current-downloads: Other Current Downloads
current: LTS
current: Current
lts: LTS
tagline-current: Latest Features
tagline-lts: Recommended For Most Users
Expand Down
6 changes: 3 additions & 3 deletions scripts/helpers/latestversion.js
Expand Up @@ -9,9 +9,9 @@ const map = (release) => release && {
openssl: release.openssl
}

exports.lts = (releases) => {
const match = releases.find((release) => release.lts && semver.lte(release.version, '5.0.0'))
exports.current = (releases) => {
const match = releases.find((release) => !release.lts && semver.gte(release.version, '5.0.0'))
return map(match)
}

exports.current = (releases) => map(releases.find((release) => release.lts))
exports.lts = (releases) => map(releases.find((release) => release.lts))
56 changes: 56 additions & 0 deletions tests/scripts/latestversion.test.js
@@ -0,0 +1,56 @@
'use strict'

const test = require('tape')

const latestversion = require('../../scripts/helpers/latestversion')

test('latestversion.current()', (t) => {
t.test('should be greater equal/greater than v5.0.0', (t) => {
const currentVersion = latestversion.current([
{ version: 'v4.2.1', lts: true },
{ version: 'v0.12.7', lts: false }
])

t.equal(currentVersion, undefined)
t.end()
})

t.test('should not be an LTS release', (t) => {
const currentVersion = latestversion.current([
{ version: 'v5.0.0', lts: false },
{ version: 'v4.2.1', lts: true },
{ version: 'v0.12.7', lts: false }
])

t.equal(currentVersion.node, 'v5.0.0')
t.end()
})

t.end()
})

test('latestversion.lts()', (t) => {
t.test('should be an LTS release', (t) => {
const ltsVersion = latestversion.lts([
{ version: 'v4.2.1', lts: true },
{ version: 'v0.12.7', lts: false }
])

t.equal(ltsVersion.node, 'v4.2.1')
t.end()
})

t.test('should pick latest LTS release', (t) => {
const ltsVersion = latestversion.lts([
{ version: 'v5.0.0', lts: false },
{ version: 'v4.2.1', lts: true },
{ version: 'v4.2.0', lts: true },
{ version: 'v0.12.7', lts: false }
])

t.equal(ltsVersion.node, 'v4.2.1')
t.end()
})

t.end()
})

0 comments on commit 14805d5

Please sign in to comment.