Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6.x lts release #973

Merged
merged 1 commit into from Oct 18, 2016
Merged

V6.x lts release #973

merged 1 commit into from Oct 18, 2016

Conversation

MylesBorins
Copy link
Member

This is a band aid solution for now that changes the copy for v6.x to be LTS rather than Current. It replaces the references to Current with LTS, and modifies some of the copy. I have a separate fork that we should land that will revert this change and update the copy for v7.x

meta: switch v6.x to LTS (TO BE REVERTED)
12e1bc9 
This is a band aid solution for now that changes the copy for v6.x
to be LTS rather than Current. This should be reverted when we release
v7.x

This removed tests and hacks `scripts/helpers/latestversion.js` to
get things working temporarily.
@MylesBorins
Copy link
Member Author

This has now been updated to monkey patch scripts/helpers/latestversion.js to guarantee we get the expected versions on the main page

This also removes the tests that were breaking after the change.

THIS SHOULD BE REVERTED WHEN v7 LANDS

@MylesBorins
Copy link
Member Author

/cc @nodejs/website this needs to land ASAP but I do not want to land it without at least a single LGTM. Can I please get someone to give me a thumbs up

lpinca
lpinca approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg
Copy link
Member

rvagg commented Oct 18, 2016

fixes the front page, which is probably most important, so lgtm, but it doesn't deal with https://nodejs.org/en/download/current/ which is still stuck on 6.8.1. I'm not sure how to deal with that one other than pretend that 6.9.0 is current for a week or so.

@phillipj
Copy link
Member

I have a separate fork that we should land that will revert this change and update the copy for v7.x

Goodie 👍 Would be nice if you opened a PR on that one asap, that sounds like a more permanent change and may need more discussion

@MylesBorins
Copy link
Member Author

I'm merging this for now, will look into the other route a bit later tonight. if anyone else wants to take a stab in the mean time please dl

@MylesBorins MylesBorins merged commit 8c53b4b into nodejs:master Oct 18, 2016
@lpinca
Copy link
Member

lpinca commented Oct 18, 2016

I was sure to have already put a LGTM yesterday here, but I didn't.

@lpinca
Copy link
Member

lpinca commented Oct 18, 2016

@rvagg https://nodejs.org/en/download/current/ seems to work fine.

@phillipj
Copy link
Member

.. but it doesn't deal with https://nodejs.org/en/download/current/ which is still stuck on 6.8.1

I'm also seeing v6.9.0 now, I assume you saw the old cached version of that page.

@jbergstroem
Copy link
Member

Looks good to me!

@phillipj phillipj mentioned this pull request Oct 18, 2016
Closed
jasnell pushed a commit that referenced this pull request Oct 25, 2016
@MylesBorins @jasnell
Revert "meta: switch v6.x to LTS (#973)"
14805d5 
For the release of v7.0 we should revert commit 8c53b4b

This can be trumped by #990 if it is ready for release before v7 is cut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@SamuelBolduc SamuelBolduc SamuelBolduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MylesBorins @rvagg @phillipj @lpinca @jbergstroem @SamuelBolduc