Disable current release line when not yet cut #990

phillipj · 2016-10-23T18:34:45Z

These changes makes the website handle periodes where a current release line has not been cut yet, automatically. As discussed in #982, we could grey out the "current" option, instead of two LTS options, in periodes where we don't have a current release line.

Rationale behind handling this automatically is to prevent us having to land a big PR, which we probably haven't tested much, asap after v7 has been cut. This would just work whenever v7 is out.

The main logic around this, is found in scripts/helpers/latestversion.js which picks which version should be displayed as LTS and current, plus "upcoming current" introduced with these changes. That logic is based around the list of releases in https://nodejs.org/download/release/index.json. In summary the logical rules are:

LTS: latest version in with .lts === true
Current: latest version with .lts !== true and version number greater than the latest LTS
Upcoming current: whenever current doesn't exists, calculate upcoming current to be major of LTS + 1, e.g. v6 + 1

Download page should probably have something similar implemented. Would appreciate any thoughts about how that might look. Tried simply greying out the background for "current" in the download matrix, but that really didn't look good, so I'm skipped that part for now.

Examples of how the frontpage looks depending on the versions found in https://nodejs.org/download/release/index.json.

Previously when LTS and current existed

#### When no current release is found (like now)

#### As soon as current exists again

## Tasks - [x] Frontpage - [x] Download page - [ ] Download page for current when current don't exist

This reverts commit 12e1bc9.

lpinca · 2016-10-23T21:01:35Z

scripts/helpers/latestversion.js

@@ -9,9 +9,21 @@ const map = (release) => release && {
  openssl: release.openssl
 }

+// might we undefined if the current release line has not been cut yet


Typo: we -> be

lpinca · 2016-10-23T21:02:34Z

scripts/helpers/latestversion.js

+// has not yet been cut
+exports.upcomingCurrent = (releases) => {
+  const isCurrentReleased = exports.current(releases) !== undefined
+  const ltsMajor = semver.major(exports.lts(releases).node)


It might make sense to exit early when isCurrentReleased is true.

lpinca · 2016-10-23T21:08:28Z

I like the idea, 👍.

MylesBorins · 2016-10-24T17:46:45Z

This LGTM

#992 can be closed if this lands before the v7 release.

ryanmurakami · 2016-10-24T19:39:22Z

scripts/helpers/latestversion.js

@@ -9,9 +9,21 @@ const map = (release) => release && {
  openssl: release.openssl
 }

-exports.lts = (releases) => {
-  const match = releases.find((release) => release.lts && semver.lte(release.version, '5.0.0'))
+// might we undefined if the current release line has not been cut yet


'might be' instead of 'might we'

phillipj · 2016-10-24T20:24:36Z

Been trying a couple of different approaches on the download page, it's quite obvious I'm no designer... What do you think of these ones? I'm more than open to other alternatives here :)

With upcoming current

Both release lines present

ryanmurakami · 2016-10-24T20:37:13Z

@phillipj Would the "with upcoming current" grey text be disabled? I like that approach.

phillipj · 2016-10-24T20:38:46Z

@phillipj Would the "with upcoming current" grey text be disabled? I like that approach.

Yepp, when grey it's just text, not an <a> at all.

lpinca · 2016-10-24T20:50:48Z

I think it could work. I have no better ideas (I'm also not a designer).

MylesBorins · 2016-10-24T21:02:33Z

what would be the behavior if someone visited the 'Current' url?

phillipj · 2016-10-24T21:19:19Z

Pushed a fix needed for the navigation menu found on /docs/ to work without current present:

phillipj · 2016-10-24T21:24:40Z

what would be the behavior if someone visited the 'Current' url?

@thealphanerd good catch, not particularly good I'm afraid :/ That page really doesn't handle current not being present -- see screenshot below.

I've gotta sleep now. Feel free to suggest how the /download/current/ page should be handled. I'll be available tomorrow from 07.00 UTC.

phillipj · 2016-10-25T07:10:38Z

^^ seems like a showstopper for merging this today IMO. Especially since /download/current has been valid for almost a week, pointing to LTS v6.

Thinking out loud, two options comes to mind for the /download/current when current doesn't exist:

Display it as if the latest current version actually exists (even tho it's end of life).
Display an almost empty page saying Node.js currently don't have an active current release.

Afraid I won't be able to get any of the above options implemented before v7 is hopefully released today, meaning PR #992 is probably the one to be merged today.

For the release of v7.0 we should revert commit 8c53b4b This can be trumped by #990 if it is ready for release before v7 is cut

Fishrock123 · 2016-11-07T15:05:12Z

FWIW with how this past transition went I think it is pretty safe to say we'll probably do LTS a week before the next current again next year.

fhemberger · 2017-03-25T06:33:21Z

@phillipj Hi, what's the current status of this PR?

phillipj · 2017-03-28T19:57:16Z

@fhemberger thanks, needed the reminder on this one 👍

So, this got stale cause I didn't have the time to do something with the /download/current URL. Thought I give option 2 from #990 (comment) a shot:

What do you think? Would displaying a more or less blank page like that be sufficient in the short period where current does not exist?

gibfahn · 2017-03-28T21:43:34Z

Maybe add some info about why there isn't a release line. Otherwise it looks like a "whoops, couldn't find that link" page (like we misplaced it 😁 ).

Maybe something like:

This is temporary for a week or two while the Current release line transitions into LTS.

Also if the latest LTS release was a link that would be good.

Otherwise seems reasonable to me.

phillipj · 2017-03-31T19:29:47Z

More info about why there is no Current release line and linking to the LTS download page, sounds like a good idea 👍 Little unsure about the wording you suggested:

This is temporary for a week or two while the Current release line transitions into LTS.

I read that as the Current that existed, e.g. v5, would transition into LTS after a week or two, but in reality v5 had already moved into end of life IIRC.

Maybe displaying the release plan graphics would be appropriate? Something like this:

gibfahn · 2017-03-31T20:57:33Z

I read that as the Current that existed, e.g. v5, would transition into LTS after a week or two, but in reality v5 had already moved into end of life IIRC.

When Node 7 came out, Node 5 had already been EoL for several months right? The previous Current was Node 6, and the reason there was a gap is that Node 6 was transitioning from Current -> LTS. Agreed that the wording isn't exactly obvious for people who don't already understand the release process.

phillipj · 2017-03-31T21:18:47Z

Hm, you might be right, don't remember the exact details so I looked mostly at the screenshots I took initially when opening this PR:

The most important thing is that the visitors actually understand what we're trying to communicate. Not being a native english speaker, I'm not confident I'll find something better than what already has been suggested though.

fhemberger · 2017-06-07T17:13:43Z

@phillipj Hmm, it's been a while … what's the current status of this PR? What do we need to get it merged?

phillipj · 2017-06-07T18:25:26Z

I've got too much outside of GitHub these days, family and buying/building a house, so I don't have time to follow this up and push it through I'm afraid.

If anyone sees value in this and want to get it merged, please go ahead and hijack the branch.

Closing this for now.

fhemberger · 2017-06-07T18:50:21Z

@phillipj Alright, take care!

phillipj · 2017-06-07T18:53:30Z

@fhemberger thanks, appreciated 👍

phillipj added 2 commits October 22, 2016 23:03

Revert "meta: switch v6.x to LTS (TO BE REVERTED)"

eedfcd0

This reverts commit 12e1bc9.

Frontpage: greyed out v7 coming soon

3caf6f0

phillipj added discuss on hold labels Oct 23, 2016

lpinca reviewed Oct 23, 2016

View reviewed changes

MylesBorins mentioned this pull request Oct 24, 2016

Revert "meta: switch v6.x to LTS (#973)" #992

Closed

upcoming current: exit early w/current exists

6afc7a6

ryanmurakami reviewed Oct 24, 2016

View reviewed changes

Download page: greyed out v7 coming soon

2442cda

Frontpage: make "Coming soon" tagline translatable

5c6e9d2

phillipj changed the title ~~WIP: disable current release line when not yet cut~~ Disable current release line when not yet cut Oct 24, 2016

phillipj removed the on hold label Oct 24, 2016

Docs: handle maybe not present current release

a7f4113

jasnell pushed a commit that referenced this pull request Oct 25, 2016

Revert "meta: switch v6.x to LTS (#973)"

14805d5

For the release of v7.0 we should revert commit 8c53b4b This can be trumped by #990 if it is ready for release before v7 is cut

mairead mentioned this pull request Oct 29, 2016

Download toggle for current/latest has confusing UI #947

Closed

1. shot at /download/current when *current* release line dont exist

4275c5d

phillipj closed this Jun 7, 2017

snyk-bot mentioned this pull request Feb 1, 2020

[Snyk] Fix for 1 vulnerabilities bryanweast/nodejs.org#9

Open

snyk-bot mentioned this pull request Sep 28, 2021

[Snyk] Security upgrade snyk from 1.244.0 to 1.290.1 bryanweast/nodejs.org#32

Open

bryanweast mentioned this pull request Jun 24, 2022

[Snyk] Security upgrade snyk from 1.244.0 to 1.290.1 bryanweast/nodejs.org#40

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable current release line when not yet cut #990

Disable current release line when not yet cut #990

phillipj commented Oct 23, 2016 •

edited

lpinca Oct 23, 2016

lpinca Oct 23, 2016

lpinca commented Oct 23, 2016

MylesBorins commented Oct 24, 2016

ryanmurakami Oct 24, 2016

phillipj commented Oct 24, 2016

ryanmurakami commented Oct 24, 2016

phillipj commented Oct 24, 2016

lpinca commented Oct 24, 2016

MylesBorins commented Oct 24, 2016

phillipj commented Oct 24, 2016

phillipj commented Oct 24, 2016

phillipj commented Oct 25, 2016

Fishrock123 commented Nov 7, 2016

fhemberger commented Mar 25, 2017

phillipj commented Mar 28, 2017

gibfahn commented Mar 28, 2017

phillipj commented Mar 31, 2017

gibfahn commented Mar 31, 2017

phillipj commented Mar 31, 2017

fhemberger commented Jun 7, 2017

phillipj commented Jun 7, 2017

fhemberger commented Jun 7, 2017

phillipj commented Jun 7, 2017

Disable current release line when not yet cut #990

Disable current release line when not yet cut #990

Conversation

phillipj commented Oct 23, 2016 • edited

Previously when LTS and current existed

lpinca Oct 23, 2016

Choose a reason for hiding this comment

lpinca Oct 23, 2016

Choose a reason for hiding this comment

lpinca commented Oct 23, 2016

MylesBorins commented Oct 24, 2016

ryanmurakami Oct 24, 2016

Choose a reason for hiding this comment

phillipj commented Oct 24, 2016

With upcoming current

Both release lines present

ryanmurakami commented Oct 24, 2016

phillipj commented Oct 24, 2016

lpinca commented Oct 24, 2016

MylesBorins commented Oct 24, 2016

phillipj commented Oct 24, 2016

phillipj commented Oct 24, 2016

phillipj commented Oct 25, 2016

Fishrock123 commented Nov 7, 2016

fhemberger commented Mar 25, 2017

phillipj commented Mar 28, 2017

gibfahn commented Mar 28, 2017

phillipj commented Mar 31, 2017

gibfahn commented Mar 31, 2017

phillipj commented Mar 31, 2017

fhemberger commented Jun 7, 2017

phillipj commented Jun 7, 2017

fhemberger commented Jun 7, 2017

phillipj commented Jun 7, 2017

phillipj commented Oct 23, 2016 •

edited