replace unnecessary callback functions with async/await #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wai-Dung
changed the title
Wai-Dung
changed the title
1. Some functions like 'fs' or 'graceFulFs' has been supporting 'async/await' for a long time, so this is a refactor to improve the related codes. 2. 'sass.render' is deprecated, use awaitable 'sass.compileAsync' instead.
aymen94
approved these changes
Apr 21, 2022
PWilkosz99
added a commit
to PWilkosz99/nodejs.org
that referenced
this pull request
Apr 24, 2022
* Blog: Node.js 18 release announcement Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Ethan Arrowood <ethan@arrowood.dev> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> * Blog: v18.0.0 release post Refs: nodejs/node#42262 * fix: add Node.js 16.x and 17.x to generated version link list (nodejs#4545) * fix: add Node.js 16.x and 17.x to generated version link list `source/nodejsVersions.md` is used to generate a list of version links on each locale page. Node.js 17.x were missing. Co-authored-by: Nick Schonning <nschonni@gmail.com> * zh-CN: update site.json for Node.js 18 (nodejs#4554) Ref: nodejs#4553 * Fix typo (nodejs#4557) "to be trust" should be "to trust" as a transitive verb. * doc: update link about class features optimizations in Node.js 18 (nodejs#4556) There is a blog post explaining about this now, change the link. * doc: typo fix (nodejs#4558) Add missing "to" between the two verbs as a typo fix. * doc: fix wrong link for "windows" (nodejs#4514) The anchor to Windows installation session now points to "install nvs on Windows". This PR fixes the anchor to the correct location. * chore: replace callbacks with necessary async/await (nodejs#4555) 1. Some functions like 'fs' or 'graceFulFs' has been supporting 'async/await' for a long time, so this is a refactor to improve the related codes. 2. 'sass.render' is deprecated, use awaitable 'sass.compileAsync' instead. * Remove call to deprecated function util.inherits (nodejs#4483) * Remove call to deprecated function util.inherits * Update event-loop-timers-and-nexttick.md Co-authored-by: Rich Trott <rtrott@gmail.com> * Meetup sweden stockholm (nodejs#4407) Add the meetup for sweden stockholm. Co-authored-by: Beth Griggs <bgriggs@redhat.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Ethan Arrowood <ethan@arrowood.dev> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Co-authored-by: Austin Kelleher <austinlkelleher@gmail.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Maledong <maledong_public@foxmail.com> Co-authored-by: Kenny <67985757+protofarer@users.noreply.github.com> Co-authored-by: Javad <79276645+Javad-93@users.noreply.github.com> Co-authored-by: Tse Kit Yam <tsekityam@users.noreply.github.com> Co-authored-by: Bart Louwers <bart.louwers@gmail.com> Co-authored-by: lxmarinkovic <lxmarinkovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions like 'fs' or 'graceFulFs' has been supporting
'async/await' for a long time, so this is a refactor to improve
the related codes and performance when building.
'sass.render' is deprecated, use awaitable 'sass.compileAsync'
instead.