Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct redirect for security #5622

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Aug 9, 2023

Description

Corrected where https://nodejs.org/en/security/ gets redirected to.

Validation

Related Issues

Fixes: #5621
Refs: #5601

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

Fixes: #5621

Signed-off-by: Richard Lau <rlau@redhat.com>
@richardlau richardlau requested a review from a team as a code owner August 9, 2023 18:21
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 7:31pm

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did a little typo over here.

@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2023

@richardlau prettier is complaining about the file, can you run npm run prettier:fix locally?

@richardlau
Copy link
Member Author

@richardlau prettier is complaining about the file, can you run npm run prettier:fix locally?

Not right now -- I did this PR in a web browser and not on my work computer.

@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2023

@richardlau prettier is complaining about the file, can you run npm run prettier:fix locally?

Not right now -- I did this PR in a web browser and not on my work computer.

You can use Codespaces, or simply https://github.dev/nodejs/nodejs.org/tree/richardlau-fix-security-rewrite (I've just done that for you!)

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 8.602s ⏱️

@bmuenzenmeyer
Copy link
Collaborator

merging this as a hotfix

@bmuenzenmeyer bmuenzenmeyer merged commit 9a45ee1 into main Aug 9, 2023
11 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the richardlau-fix-security-rewrite branch August 9, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong redirect for https://nodejs.org/en/security/
3 participants