-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct redirect for security #5622
Conversation
Fixes: #5621 Signed-off-by: Richard Lau <rlau@redhat.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did a little typo over here.
@richardlau prettier is complaining about the file, can you run |
Not right now -- I did this PR in a web browser and not on my work computer. |
You can use Codespaces, or simply https://github.dev/nodejs/nodejs.org/tree/richardlau-fix-security-rewrite (I've just done that for you!) |
a298e05
to
c503941
Compare
merging this as a hotfix |
Description
Corrected where https://nodejs.org/en/security/ gets redirected to.
Validation
Related Issues
Fixes: #5621
Refs: #5601
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing, and/ornpx turbo test:snapshot
to update snapshots if I created and/or updated React Components.