-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to security policy from blog post is 404ing #5601
Comments
I used archive.org to see what the previous content looks like https://web.archive.org/web/20210424084328/https://nodejs.org/en/security/ It seems to match what is in https://github.com/nodejs/node/blob/main/SECURITY.md - but some of the previous blog posts have the same output. So to me the resolution is introducing a new redirect for the same similar to this one 9f67d43#diff-d9eafd123ac764afabc33ffcd1ee502a081b3342ee5f739f0fb9ef8e8d1764c1R26-R30. |
Well we do have a https://nodejs.org/en/docs/guides/security which I have no idea how outdated it is. But yes, I would rather update the blogpost to redirect to /en/about/secuity (https://github.com/nodejs/nodejs.org/blob/main/next.rewrites.mjs#L61-L64) which in the end goes to https://github.com/nodejs/node/blob/HEAD/SECURITY.md#security |
cc @nodejs/security @RafaelGSS |
Yes, there are two distinct routes:
For the second one I believe we should add a redirect to the github/nodejs/node/SECURITY.md. |
I'm not familiar with the /security route. @RafaelGSS from where did you getting the reference of this route? I believe the route you want is /en/about/security or just /about/security which should go to the README.md#security |
@ovflowd See https://web.archive.org/web/20220624004851/https://nodejs.org/en/security/. It redirects to nodejs/node/SECURITY.md. We should keep this behavior. |
Can I work on this🤞? |
For the security policy, don’t redirect to the file - instead, redirect to https://github.com/nodejs/node/security/policy |
We can discuss about changing the blog post template(s), but the website is supposed to have a redirect: https://github.com/nodejs/build/blob/f7e0f90a55b0c866041668e4285a16274f1e36f7/ansible/www-standalone/resources/config/nodejs.org?plain=1#L344 |
I was just about to say what @targos mentioned. I guess I forgot about this one. Or intentionally removed it. I'm going to re-add it. -- Nope @sohan2410 sorry, this is kinda priority so I wanted to apply a hot and clean fix. Thanks anyways! |
FYI I've made a hot-fix already, https://nodejs.org/en/security or /security or /any-supported-language/security redirects now to the correct endpoint. |
URL:
https://nodejs.org/en/blog/vulnerability/august-2023-security-releases
Browser Name:
Arc
Browser Version:
1.1.1
Operating System:
Mac OS Ventura 13.4.1
How to reproduce the issue:
The Node.js blogpost about the upcoming security release (authored by Rafael Gonzaga)
The bottom link to the security policy is 404-ing, you probably want https://nodejs.org/en/docs/guides/security or straight up to the GH security.md?
I have not verified other blog posts.
The text was updated successfully, but these errors were encountered: