fix: update Project governance page to match reality #6493
Conversation
I noticed that the governance page (source is https://github.com/nodejs/nodejs.org/blob/main/pages/en/about/governance.md) appears to be out of sync and probably is copied from an older document that used incorrect descriptions. At least it does not match what we say in https://github.com/nodejs/node/blob/main/GOVERNANCE.md now and I remember we made sure that it was clear it's collaborators who nominate collaborators (which is also what we do in practice). Here is my attempt at clarifying the text. cc @nodejs/tsc Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
You mean as a link to the actual Markdown doc? I'm fine with that, also. |
However you want to do it; a link, or pulling that document into the build for the website somehow, whatever. Having two copies of it just means two things that can get out of sync, or worse, two places to haggle over language. |
|
I think it's nice to have a brief summary of the governance model - I doubt how many browsing our websites would be entertained reading the long governance doc. Another solution is to have a TL;DR in the governance doc, and somehow sync that part to the website, or on the website only render the TL;DR |
I noticed that the governance page (source is https://github.com/nodejs/nodejs.org/blob/main/pages/en/about/governance.md) appears to be out of sync and probably is copied from an older document that used incorrect descriptions. At least it does not match what we say in https://github.com/nodejs/node/blob/main/GOVERNANCE.md now and I remember we made sure that it was clear it's collaborators who nominate collaborators (which is also what we do in practice).
Here is my attempt at clarifying the text.
cc @nodejs/tsc
Description
Validation
Related Issues
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.