Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run compare on perf cores #162

Merged
merged 2 commits into from
Apr 10, 2024
Merged

run compare on perf cores #162

merged 2 commits into from
Apr 10, 2024

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Apr 10, 2024

this should fix the issue with taskset in the compare CLI:

not configurable to avoid command injection possibility

After merging this, should revert the pr:

./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName

# Run on performance cores
taskset -c 0-11 ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fail on non-linux environments I assume? Can we make it work with Windows and macOS as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @richardlau is not runnable outside the build infra

@richardlau
Copy link
Member

not configurable to avoid command injection possibility

FWIW the script is currently specific to the Build infra as it uses the select-compiler.sh script, so hard coding the taskset parameter (for now) is reasonable. I'll leave it up to the performance team if they want this script to be runnable outside of the CI.

@rluvaton
Copy link
Member Author

maybe we can close this if we merge

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we are not running these in anything but linux

@anonrig anonrig merged commit d7c619a into main Apr 10, 2024
@rluvaton rluvaton deleted the run-compare-on-perf-cores branch April 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants