Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes Readable.fromWeb and Readable.toWeb methods #506

Merged
merged 3 commits into from
May 8, 2023
Merged

fix: removes Readable.fromWeb and Readable.toWeb methods #506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de43dd6
removing obsolete methods from Readable class
RishabhKodes Feb 26, 2023
651395a
moved the logic to replacements.mjs
RishabhKodes Feb 27, 2023
13f8c64
using the replacements.mjs logic
RishabhKodes Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions build/replacements.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ const testParallelTicksReenableConsoleLog = ['silentConsole.log\\(i\\);', 'conso

const testParallelTickSaveHook = ['async_hooks.createHook\\(\\{', 'const hook = async_hooks.createHook({']

const removefromWebReadableMethod = ['Readable.fromWeb = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}', '']

const removetoWebReadableMethod = ['Readable.toWeb = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}', '']

const readmeInfo = ['(This package is a mirror of the streams implementations in Node.js) (\\d+.\\d+.\\d+).', '$1 $2.']

const readmeLink = ['(\\[Node.js website\\]\\(https://nodejs.org/dist/v)(\\d+.\\d+.\\d+)', '$1$2']
Expand All @@ -232,6 +236,10 @@ export const replacements = {
internalStreamsAbortControllerPolyfill,
internalStreamsNoRequireAbortController
],
'lib/internal/streams/readable.js': [
removefromWebReadableMethod,
removetoWebReadableMethod
],
'lib/internal/streams/.+': [
internalStreamsRequireErrors,
internalStreamsRequireEventEmitter,
Expand Down